Skip to content

Commit 3839951

Browse files
authored
feat(aci): Make detector list table properly responsive (#94211)
1 parent 377e7d8 commit 3839951

File tree

1 file changed

+45
-39
lines changed
  • static/app/views/detectors/components/detectorListTable

1 file changed

+45
-39
lines changed

static/app/views/detectors/components/detectorListTable/index.tsx

Lines changed: 45 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -74,77 +74,83 @@ function DetectorListTable({
7474
sort,
7575
}: DetectorListTableProps) {
7676
return (
77-
<DetectorListSimpleTable>
78-
<SimpleTable.Header>
79-
<HeaderCell name="name" sortKey="name" sort={sort}>
80-
{t('Name')}
81-
</HeaderCell>
82-
<HeaderCell name="type" divider sortKey="type" sort={sort}>
83-
{t('Type')}
84-
</HeaderCell>
85-
<HeaderCell name="issue" divider sort={sort}>
86-
{t('Last Issue')}
87-
</HeaderCell>
88-
<HeaderCell name="assignee" divider sort={sort}>
89-
{t('Assignee')}
90-
</HeaderCell>
91-
<HeaderCell
92-
name="connected-automations"
93-
divider
94-
sortKey="connectedWorkflows"
95-
sort={sort}
96-
>
97-
{t('Automations')}
98-
</HeaderCell>
99-
</SimpleTable.Header>
100-
{isError && <LoadingError message={t('Error loading monitors')} />}
101-
{isPending && <LoadingSkeletons />}
102-
{isSuccess && detectors.length > 0 ? (
103-
detectors.map(detector => (
104-
<DetectorListRow key={detector.id} detector={detector} />
105-
))
106-
) : (
107-
<SimpleTable.Empty>{t('No monitors found')}</SimpleTable.Empty>
108-
)}
109-
</DetectorListSimpleTable>
77+
<Container>
78+
<DetectorListSimpleTable>
79+
<SimpleTable.Header>
80+
<HeaderCell name="name" sortKey="name" sort={sort}>
81+
{t('Name')}
82+
</HeaderCell>
83+
<HeaderCell name="type" divider sortKey="type" sort={sort}>
84+
{t('Type')}
85+
</HeaderCell>
86+
<HeaderCell name="last-issue" divider sort={sort}>
87+
{t('Last Issue')}
88+
</HeaderCell>
89+
<HeaderCell name="assignee" divider sort={sort}>
90+
{t('Assignee')}
91+
</HeaderCell>
92+
<HeaderCell
93+
name="connected-automations"
94+
divider
95+
sortKey="connectedWorkflows"
96+
sort={sort}
97+
>
98+
{t('Automations')}
99+
</HeaderCell>
100+
</SimpleTable.Header>
101+
{isError && <LoadingError message={t('Error loading monitors')} />}
102+
{isPending && <LoadingSkeletons />}
103+
{isSuccess && detectors.length > 0 ? (
104+
detectors.map(detector => (
105+
<DetectorListRow key={detector.id} detector={detector} />
106+
))
107+
) : (
108+
<SimpleTable.Empty>{t('No monitors found')}</SimpleTable.Empty>
109+
)}
110+
</DetectorListSimpleTable>
111+
</Container>
110112
);
111113
}
112114

115+
const Container = styled('div')`
116+
container-type: inline-size;
117+
`;
118+
113119
const DetectorListSimpleTable = styled(SimpleTable)`
114120
grid-template-columns: 1fr;
115121
116122
.type,
117-
.creator,
118123
.last-issue,
124+
.assignee,
119125
.connected-automations {
120126
display: none;
121127
}
122128
123-
@media (min-width: ${p => p.theme.breakpoints.xsmall}) {
129+
@container (min-width: ${p => p.theme.breakpoints.xsmall}) {
124130
grid-template-columns: 3fr 0.8fr;
125131
126132
.type {
127133
display: flex;
128134
}
129135
}
130136
131-
@media (min-width: ${p => p.theme.breakpoints.small}) {
137+
@container (min-width: ${p => p.theme.breakpoints.small}) {
132138
grid-template-columns: 3fr 0.8fr 1.5fr 0.8fr;
133139
134140
.last-issue {
135141
display: flex;
136142
}
137143
}
138144
139-
@media (min-width: ${p => p.theme.breakpoints.medium}) {
145+
@container (min-width: ${p => p.theme.breakpoints.medium}) {
140146
grid-template-columns: 3fr 0.8fr 1.5fr 0.8fr;
141147
142-
.creator {
148+
.assignee {
143149
display: flex;
144150
}
145151
}
146152
147-
@media (min-width: ${p => p.theme.breakpoints.large}) {
153+
@container (min-width: ${p => p.theme.breakpoints.large}) {
148154
grid-template-columns: 4.5fr 0.8fr 1.5fr 0.8fr 2fr;
149155
150156
.connected-automations {

0 commit comments

Comments
 (0)