Skip to content

Commit 348600c

Browse files
committed
wip
1 parent 05ca85a commit 348600c

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

static/app/views/insights/cache/components/samplePanel.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ export function CacheSamplePanel() {
6464
const location = useLocation();
6565
const organization = useOrganization();
6666
const {selection} = usePageFilters();
67-
const useEap = useInsightsEap();
6867

6968
const query = useLocationQuery({
7069
fields: {

static/app/views/insights/common/components/spanDescription.tsx

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import useOrganization from 'sentry/utils/useOrganization';
1313
import useProjects from 'sentry/utils/useProjects';
1414
import {useRelease} from 'sentry/utils/useRelease';
1515
import {useSpansIndexed} from 'sentry/views/insights/common/queries/useDiscover';
16-
import {useEventDetails} from 'sentry/views/insights/common/queries/useEventDetails';
1716
import {useFullSpanFromTrace} from 'sentry/views/insights/common/queries/useFullSpanFromTrace';
1817
import {useInsightsEap} from 'sentry/views/insights/common/utils/useEap';
1918
import {
@@ -62,7 +61,6 @@ export function DatabaseSpanDescription({
6261
limit: 1,
6362
fields: [
6463
SpanIndexedField.PROJECT_ID,
65-
SpanIndexedField.TRANSACTION_ID, // TODO: remove this with `useInsightsEap`, it's only needed to get the full event when eap is off
6664
SpanIndexedField.SPAN_DESCRIPTION,
6765
SpanIndexedField.DB_SYSTEM,
6866
SpanIndexedField.CODE_FILEPATH,
@@ -81,11 +79,6 @@ export function DatabaseSpanDescription({
8179

8280
const project = projects.find(p => p.id === indexedSpan?.project_id?.toString());
8381

84-
const {data: eventDetailsData} = useEventDetails({
85-
eventId: indexedSpan?.['transaction.id'],
86-
projectSlug: project?.slug,
87-
});
88-
8982
const {data: release} = useRelease({
9083
orgSlug: organization.slug,
9184
projectSlug: project?.slug ?? '',
@@ -101,13 +94,11 @@ export function DatabaseSpanDescription({
10194
}
10295
: undefined;
10396

104-
const event = useEap
105-
? {
106-
platform: indexedSpan?.platform,
107-
release,
108-
sdk,
109-
}
110-
: eventDetailsData;
97+
const event = {
98+
platform: indexedSpan?.platform,
99+
release,
100+
sdk,
101+
};
111102

112103
// NOTE: We only need this for `span.data`! If this info existed in indexed spans, we could skip it
113104
const {data: rawSpan, isFetching: isRawSpanLoading} = useFullSpanFromTrace(

static/app/views/insights/types.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,6 @@ export enum SpanIndexedField {
364364
SDK_NAME = 'sdk.name',
365365
SDK_VERSION = 'sdk.version',
366366
TRACE = 'trace',
367-
TRANSACTION_ID = 'transaction.id', // TODO - remove this with `useInsightsEap`
368367
TRANSACTION_SPAN_ID = 'transaction.span_id',
369368
TRANSACTION_METHOD = 'transaction.method',
370369
TRANSACTION_OP = 'transaction.op',

0 commit comments

Comments
 (0)