feat(billing): Formatting utility for Logs (#95450)

Closes:
https://linear.app/getsentry/issue/BIL-1098/add-formatting-for-changeplanaction

Refactors duplicate byte category checks into a reusable utility
function

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: jarrettscott

static/gsAdmin/components/planList.tsx

@@ -9,13 +9,13 @@ import Form from 'sentry/components/forms/form';
 import type FormModel from 'sentry/components/forms/model';
 import type {Data, OnSubmitCallback} from 'sentry/components/forms/types';
 import {space} from 'sentry/styles/space';
-import {DataCategory} from 'sentry/types/core';
+import type {DataCategory} from 'sentry/types/core';
 import type {Organization} from 'sentry/types/organization';
 import {toTitleCase} from 'sentry/utils/string/toTitleCase';
 
 import {ANNUAL} from 'getsentry/constants';
 import type {BillingConfig, Plan, Subscription} from 'getsentry/types';
-import {getPlanCategoryName} from 'getsentry/utils/dataCategory';
+import {getPlanCategoryName, isByteCategory} from 'getsentry/utils/dataCategory';
 import formatCurrency from 'getsentry/utils/formatCurrency';
 
 type Props = {
@@ -58,7 +58,7 @@ function PlanList({
         return (
           <CurrentValueText>
             Current: {reservedValue.toLocaleString()}{' '}
-            {category === DataCategory.ATTACHMENTS ? 'GB' : ''}
+            {isByteCategory(category) ? 'GB' : ''}
           </CurrentValueText>
         );
       }
@@ -147,10 +147,9 @@ function PlanList({
               const reservedKey = `reserved${toTitleCase(category, {
                 allowInnerUpperCase: true,
               })}`;
-              const label =
-                category === DataCategory.ATTACHMENTS
-                  ? `${titleCategory} (GB)`
-                  : titleCategory;
+              const label = isByteCategory(category)
+                ? `${titleCategory} (GB)`
+                : titleCategory;
               const fieldValue = formModel.getValue(reservedKey);
               const currentValueDisplay = getCurrentValueDisplay(category);
               return (

static/gsApp/utils/billing.tsx

@@ -26,7 +26,7 @@ import type {
   Subscription,
 } from 'getsentry/types';
 import {OnDemandBudgetMode, PlanName, PlanTier} from 'getsentry/types';
-import {isContinuousProfiling} from 'getsentry/utils/dataCategory';
+import {isByteCategory, isContinuousProfiling} from 'getsentry/utils/dataCategory';
 import titleCase from 'getsentry/utils/titleCase';
 import {displayPriceWithCents} from 'getsentry/views/amCheckout/utils';
 
@@ -138,10 +138,7 @@ export function formatReservedWithUnits(
   if (isReservedBudget) {
     return displayPriceWithCents({cents: reservedQuantity ?? 0});
   }
-  if (
-    dataCategory !== DataCategory.ATTACHMENTS &&
-    dataCategory !== DataCategory.LOG_BYTE
-  ) {
+  if (!isByteCategory(dataCategory)) {
     return formatReservedNumberToString(reservedQuantity, options);
   }
   // convert reservedQuantity to BYTES to check for unlimited
@@ -168,10 +165,7 @@ export function formatUsageWithUnits(
   dataCategory: DataCategory,
   options: FormatOptions = {isAbbreviated: false, useUnitScaling: false}
 ) {
-  if (
-    dataCategory === DataCategory.ATTACHMENTS ||
-    dataCategory === DataCategory.LOG_BYTE
-  ) {
+  if (isByteCategory(dataCategory)) {
     if (options.useUnitScaling) {
       return formatByteUnits(usageQuantity);
     }

static/gsApp/views/subscriptionPage/reservedUsageChart.tsx

@@ -54,6 +54,7 @@ import {
 import {
   getPlanCategoryName,
   hasCategoryFeature,
+  isByteCategory,
   isPartOfReservedBudget,
 } from 'getsentry/utils/dataCategory';
 import formatCurrency from 'getsentry/utils/formatCurrency';
@@ -188,7 +189,7 @@ function mapReservedToChart(reserved: number | null, category: DataCategory) {
     return 0;
   }
 
-  if (category === DataCategory.ATTACHMENTS) {
+  if (isByteCategory(category)) {
     return typeof reserved === 'number' ? reserved * GIGABYTE : 0;
   }
   return reserved || 0;

static/gsApp/views/subscriptionPage/usageAlert.tsx

@@ -23,7 +23,11 @@ import {
   isUnlimitedReserved,
   UsageAction,
 } from 'getsentry/utils/billing';
-import {getPlanCategoryName, sortCategoriesWithKeys} from 'getsentry/utils/dataCategory';
+import {
+  getPlanCategoryName,
+  isByteCategory,
+  sortCategoriesWithKeys,
+} from 'getsentry/utils/dataCategory';
 
 import {ButtonWrapper, SubscriptionBody} from './styles';
 
@@ -86,8 +90,9 @@ function UsageAlert({subscription, usage}: Props) {
           return acc;
         }
         const projected = usage.totals[category]?.projected || 0;
-        const projectedWithReservedUnit =
-          category === DataCategory.ATTACHMENTS ? projected / GIGABYTE : projected;
+        const projectedWithReservedUnit = isByteCategory(category)
+          ? projected / GIGABYTE
+          : projected;
 
         const hasOverage =
           !!currentHistory.reserved &&