Skip to content

Commit 1b89240

Browse files
ref(uptime): Default writing snuba results to true (#94822)
If uptime is enabled we should default to writing the results into snuba, since this is the only way to visualize uptime results
1 parent 1437078 commit 1b89240

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/sentry/options/defaults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3031,7 +3031,7 @@
30313031
register(
30323032
"uptime.snuba_uptime_results.enabled",
30333033
type=Bool,
3034-
default=False,
3034+
default=True,
30353035
flags=FLAG_AUTOMATOR_MODIFIABLE,
30363036
)
30373037

tests/sentry/uptime/consumers/test_results_consumer.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,7 @@ def test_missed_check_false_positive(self):
652652
extra={**result},
653653
)
654654

655+
@override_options({"uptime.snuba_uptime_results.enabled": False})
655656
def test_missed_check_updated_interval(self):
656657
result = self.create_uptime_result(self.subscription.subscription_id)
657658

@@ -803,6 +804,7 @@ def test_skip_shadow_region(self):
803804
with pytest.raises(Group.DoesNotExist):
804805
Group.objects.get(grouphash__hash=hashed_fingerprint)
805806

807+
@override_options({"uptime.snuba_uptime_results.enabled": False})
806808
def test_missed(self):
807809
features = [
808810
"organizations:uptime",
@@ -1182,6 +1184,7 @@ def test_parallel_grouping(self, mock_process_group) -> None:
11821184
assert group_1 == [result_1, result_2]
11831185
assert group_2 == [result_3]
11841186

1187+
@override_options({"uptime.snuba_uptime_results.enabled": False})
11851188
def test_provider_stats(self):
11861189
features = [
11871190
"organizations:uptime",

0 commit comments

Comments
 (0)