Skip to content

Commit 1ad226a

Browse files
authored
chore(aci): add tests for data condition list component (#94759)
adds tests and aria labels for inputs
1 parent 8f365f4 commit 1ad226a

19 files changed

+286
-13
lines changed

static/app/types/workflowEngine/dataConditions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ export enum DataConditionHandlerSubgroupType {
103103
export interface DataConditionHandler {
104104
comparisonJsonSchema: Record<string, any>;
105105
handlerGroup: DataConditionHandlerGroupType;
106-
handlerSubgroup: DataConditionHandlerSubgroupType;
107106
type: DataConditionType;
107+
handlerSubgroup?: DataConditionHandlerSubgroupType;
108108
}
109109

110110
// for keeping track of conflicting condition ids in the UI

static/app/views/automations/components/actionFilters/ageComparison.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {AutomationBuilderNumberInput} from 'sentry/components/workflowEngine/form/automationBuilderNumberInput';
22
import {AutomationBuilderSelect} from 'sentry/components/workflowEngine/form/automationBuilderSelect';
3-
import {tct} from 'sentry/locale';
3+
import {t, tct} from 'sentry/locale';
44
import type {SelectValue} from 'sentry/types/core';
55
import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
66
import type {AgeComparison} from 'sentry/views/automations/components/actionFilters/constants';
@@ -47,6 +47,7 @@ function ComparisonField() {
4747
return (
4848
<AutomationBuilderSelect
4949
name={`${condition_id}.comparison.comparison_type`}
50+
aria-label={t('Comparison')}
5051
value={condition.comparison.comparison_type}
5152
options={AGE_COMPARISON_CHOICES}
5253
onChange={(option: SelectValue<AgeComparison>) => {
@@ -61,6 +62,7 @@ function ValueField() {
6162
return (
6263
<AutomationBuilderNumberInput
6364
name={`${condition_id}.comparison.value`}
65+
aria-label={t('Value')}
6466
value={condition.comparison.value}
6567
min={0}
6668
step={1}
@@ -77,6 +79,7 @@ function TimeField() {
7779
return (
7880
<AutomationBuilderSelect
7981
name={`${condition_id}.comparison.time`}
82+
aria-label={t('Time unit')}
8083
value={condition.comparison.time}
8184
options={TIME_CHOICES}
8285
onChange={(option: SelectValue<TimeUnit>) => {

static/app/views/automations/components/actionFilters/assignedTo.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ function TargetTypeField() {
5656
return (
5757
<AutomationBuilderSelect
5858
name={`${condition_id}.comparison.targetType`}
59+
aria-label={t('Assignee type')}
5960
value={condition.comparison.targetType}
6061
options={TARGET_TYPE_CHOICES}
6162
onChange={(option: SelectValue<string>) =>
@@ -80,6 +81,7 @@ function IdentifierField() {
8081
<SelectWrapper>
8182
<TeamSelector
8283
name={`${condition_id}.data.targetIdentifier`}
84+
aria-label={t('Team')}
8385
value={condition.comparison.targetIdentifier}
8486
onChange={(value: SelectValue<string>) =>
8587
onUpdate({comparison: {...condition.comparison, targetIdentifier: value}})
@@ -97,6 +99,7 @@ function IdentifierField() {
9799
<SelectMembers
98100
organization={organization}
99101
key={`${condition_id}.data.targetIdentifier`}
102+
aria-label={t('Member')}
100103
value={condition.comparison.targetIdentifier}
101104
onChange={(value: any) =>
102105
onUpdate({

static/app/views/automations/components/actionFilters/comparisonBranches.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {AutomationBuilderNumberInput} from 'sentry/components/workflowEngine/form/automationBuilderNumberInput';
22
import {AutomationBuilderSelect} from 'sentry/components/workflowEngine/form/automationBuilderSelect';
3-
import {tct} from 'sentry/locale';
3+
import {t, tct} from 'sentry/locale';
44
import type {SelectValue} from 'sentry/types/core';
55
import {
66
COMPARISON_INTERVAL_CHOICES,
@@ -28,6 +28,7 @@ function ValueField() {
2828
return (
2929
<AutomationBuilderNumberInput
3030
name={`${condition_id}.comparison.value`}
31+
aria-label={t('Value')}
3132
value={condition.comparison.value}
3233
min={1}
3334
step={1}
@@ -44,6 +45,7 @@ function IntervalField() {
4445
return (
4546
<AutomationBuilderSelect
4647
name={`${condition_id}.comparison.interval`}
48+
aria-label={t('Interval')}
4749
value={condition.comparison.interval}
4850
options={INTERVAL_CHOICES}
4951
onChange={(option: SelectValue<string>) => {
@@ -58,6 +60,7 @@ function ComparisonIntervalField() {
5860
return (
5961
<AutomationBuilderSelect
6062
name={`${condition_id}.comparison.comparison_interval`}
63+
aria-label={t('Comparison interval')}
6164
value={condition.comparison.comparison_interval}
6265
options={COMPARISON_INTERVAL_CHOICES}
6366
onChange={(option: SelectValue<string>) => {

static/app/views/automations/components/actionFilters/eventAttribute.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ function AttributeField() {
3232
return (
3333
<AutomationBuilderSelect
3434
name={`${condition_id}.comparison.attribute`}
35+
aria-label={t('Attribute')}
3536
placeholder={t('attribute')}
3637
value={condition.comparison.attribute}
3738
options={Object.values(Attributes).map(attribute => ({
@@ -50,6 +51,7 @@ function MatchField() {
5051
return (
5152
<AutomationBuilderSelect
5253
name={`${condition_id}.comparison.match`}
54+
aria-label={t('Match type')}
5355
value={condition.comparison.match}
5456
options={MATCH_CHOICES}
5557
onChange={(value: MatchType) => {
@@ -64,6 +66,7 @@ function ValueField() {
6466
return (
6567
<AutomationBuilderInput
6668
name={`${condition_id}.comparison.value`}
69+
aria-label={t('Value')}
6770
placeholder={t('value')}
6871
value={condition.comparison.value}
6972
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {

static/app/views/automations/components/actionFilters/eventFrequency.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ function ComparisonTypeField() {
9393
return (
9494
<AutomationBuilderSelect
9595
name={`${condition_id}.type`}
96+
aria-label={t('Comparison type')}
9697
value={condition.type}
9798
options={[
9899
{

static/app/views/automations/components/actionFilters/eventUniqueUserFrequency.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ function ComparisonTypeField() {
105105
return (
106106
<AutomationBuilderSelect
107107
name={`${condition_id}.type`}
108+
aria-label={t('Comparison type')}
108109
value={condition.type}
109110
options={[
110111
{

static/app/views/automations/components/actionFilters/issueOccurrences.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {AutomationBuilderNumberInput} from 'sentry/components/workflowEngine/form/automationBuilderNumberInput';
2-
import {tct} from 'sentry/locale';
2+
import {t, tct} from 'sentry/locale';
33
import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
44
import {useDataConditionNodeContext} from 'sentry/views/automations/components/dataConditionNodes';
55

@@ -20,6 +20,7 @@ function ValueField() {
2020
return (
2121
<AutomationBuilderNumberInput
2222
name={`${condition_id}.comparison.value`}
23+
aria-label={t('Count')}
2324
value={condition.comparison.value}
2425
min={1}
2526
step={1}

static/app/views/automations/components/actionFilters/issuePriority.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {AutomationBuilderSelect} from 'sentry/components/workflowEngine/form/automationBuilderSelect';
2-
import {tct} from 'sentry/locale';
2+
import {t, tct} from 'sentry/locale';
33
import type {SelectValue} from 'sentry/types/core';
44
import type {DataCondition} from 'sentry/types/workflowEngine/dataConditions';
55
import {
@@ -18,10 +18,11 @@ export function IssuePriorityDetails({condition}: {condition: DataCondition}) {
1818

1919
export function IssuePriorityNode() {
2020
const {condition, condition_id, onUpdate} = useDataConditionNodeContext();
21-
return tct('Current issue priority is [level]', {
22-
level: (
21+
return tct('Current issue priority is [priority]', {
22+
priority: (
2323
<AutomationBuilderSelect
2424
name={`${condition_id}.comparison`}
25+
aria-label={t('Priority')}
2526
value={condition.comparison}
2627
options={PRIORITY_CHOICES}
2728
onChange={(option: SelectValue<Priority>) => {

static/app/views/automations/components/actionFilters/latestAdoptedRelease.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ function ReleaseAgeTypeField() {
4646
return (
4747
<AutomationBuilderSelect
4848
name={`${condition_id}.comparison.release_age_type`}
49+
aria-label={t('Release age type')}
4950
value={condition.comparison.release_age_type}
5051
options={MODEL_AGE_CHOICES}
5152
onChange={(option: SelectValue<ModelAge>) => {
@@ -60,6 +61,7 @@ function AgeComparisonField() {
6061
return (
6162
<AutomationBuilderSelect
6263
name={`${condition_id}.comparison.age_comparison`}
64+
aria-label={t('Age comparison')}
6365
value={condition.comparison.age_comparison}
6466
options={AGE_COMPARISON_CHOICES}
6567
onChange={(option: SelectValue<AgeComparison>) => {
@@ -81,6 +83,7 @@ function EnvironmentField() {
8183
return (
8284
<AutomationBuilderSelect
8385
name={`${condition_id}.comparison.environment`}
86+
aria-label={t('Environment')}
8487
value={condition.comparison.environment}
8588
options={environmentOptions}
8689
placeholder={t('environment')}

0 commit comments

Comments
 (0)