Skip to content

Commit 19176fb

Browse files
committed
ref(analytics): Transform analytics events for TET-832
- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-832
1 parent 986ceec commit 19176fb

34 files changed

+342
-399
lines changed
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("codeowners.assignment")
45
class CodeownersAssignment(analytics.Event):
5-
type = "codeowners.assignment"
6-
7-
attributes = (
8-
analytics.Attribute("organization_id"),
9-
analytics.Attribute("project_id"),
10-
analytics.Attribute("group_id"),
11-
analytics.Attribute("updated_assignment"),
12-
)
6+
organization_id: str
7+
project_id: str
8+
group_id: str
9+
updated_assignment: str
1310

1411

1512
analytics.register(CodeownersAssignment)
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("cron_monitor_broken_status.recovery")
45
class CronMonitorBrokenStatusRecovery(analytics.Event):
5-
type = "cron_monitor_broken_status.recovery"
6-
7-
attributes = (
8-
analytics.Attribute("organization_id"),
9-
analytics.Attribute("project_id"),
10-
analytics.Attribute("monitor_id"),
11-
analytics.Attribute("monitor_env_id"),
12-
)
6+
organization_id: str
7+
project_id: str
8+
monitor_id: str
9+
monitor_env_id: str
1310

1411

1512
analytics.register(CronMonitorBrokenStatusRecovery)
Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("eventuser_equality.check")
45
class EventUserEqualityCheck(analytics.Event):
5-
type = "eventuser_equality.check"
6-
7-
attributes = (
8-
analytics.Attribute("event_id"),
9-
analytics.Attribute("project_id"),
10-
analytics.Attribute("group_id"),
11-
analytics.Attribute("snuba_eventuser_equality", type=bool),
12-
analytics.Attribute("event_eventuser_equality", type=bool),
13-
analytics.Attribute("snuba_event_equality", type=bool),
14-
)
6+
event_id: str
7+
project_id: str
8+
group_id: str
9+
snuba_eventuser_equality: bool
10+
event_eventuser_equality: bool
11+
snuba_event_equality: bool
1512

1613

1714
analytics.register(EventUserEqualityCheck)
Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("first_user_context.sent")
45
class FirstUserContextSentEvent(analytics.Event):
5-
type = "first_user_context.sent"
6-
7-
attributes = (
8-
analytics.Attribute("user_id"),
9-
analytics.Attribute("organization_id"),
10-
analytics.Attribute("project_id"),
11-
)
6+
user_id: str
7+
organization_id: str
8+
project_id: str
129

1310

1411
analytics.register(FirstUserContextSentEvent)
Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("integrations.failed_to_fetch_commit_context")
45
class IntegrationsFailedToFetchCommitContext(analytics.Event):
5-
type = "integrations.failed_to_fetch_commit_context"
6-
7-
attributes = (
8-
analytics.Attribute("organization_id"),
9-
analytics.Attribute("project_id"),
10-
analytics.Attribute("code_mapping_id"),
11-
analytics.Attribute("group_id"),
12-
analytics.Attribute("provider", type=str),
13-
analytics.Attribute("error_message", type=str),
14-
)
6+
organization_id: str
7+
project_id: str
8+
code_mapping_id: str
9+
group_id: str
10+
provider: str
11+
error_message: str
1512

1613

1714
analytics.register(IntegrationsFailedToFetchCommitContext)
Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("integrations.pipeline_step")
45
class IntegrationPipelineStep(analytics.Event):
5-
type = "integrations.pipeline_step"
6-
7-
attributes = (
8-
analytics.Attribute("user_id"),
9-
analytics.Attribute("organization_id"),
10-
analytics.Attribute("integration"),
11-
analytics.Attribute("step_index"),
12-
analytics.Attribute("pipeline_type"),
13-
)
6+
user_id: str
7+
organization_id: str
8+
integration: str
9+
step_index: str
10+
pipeline_type: str
1411

1512

1613
analytics.register(IntegrationPipelineStep)
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("issueowners.assignment")
45
class IssueOwnersAssignment(analytics.Event):
5-
type = "issueowners.assignment"
6-
7-
attributes = (
8-
analytics.Attribute("organization_id"),
9-
analytics.Attribute("project_id"),
10-
analytics.Attribute("group_id"),
11-
analytics.Attribute("updated_assignment"),
12-
)
6+
organization_id: str
7+
project_id: str
8+
group_id: str
9+
updated_assignment: str
1310

1411

1512
analytics.register(IssueOwnersAssignment)
Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("join_request.created")
45
class JoinRequestCreatedEvent(analytics.Event):
5-
type = "join_request.created"
6-
7-
attributes = (
8-
analytics.Attribute("member_id"),
9-
analytics.Attribute("organization_id"),
10-
analytics.Attribute("referrer", required=False),
11-
)
6+
member_id: str
7+
organization_id: str
8+
referrer: str | None = None
129

1310

1411
analytics.register(JoinRequestCreatedEvent)
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
from sentry import analytics
22

33

4+
@analytics.eventclass("join_request.link_viewed")
45
class JoinRequestLinkViewedEvent(analytics.Event):
5-
type = "join_request.link_viewed"
6-
7-
attributes = (analytics.Attribute("organization_id"),)
6+
organization_id: str
87

98

109
analytics.register(JoinRequestLinkViewedEvent)

src/sentry/analytics/events/missing_members_nudge.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33
from sentry import analytics
44

55

6+
@analytics.eventclass("missing_members_nudge.sent")
67
class MissingMembersNudgeEvent(analytics.Event, abc.ABC):
7-
type = "missing_members_nudge.sent"
8-
attributes = [
9-
analytics.Attribute("organization_id"),
10-
]
8+
organization_id: str
119

1210

1311
analytics.register(MissingMembersNudgeEvent)

0 commit comments

Comments
 (0)