fix: webhookpayload DB constraint (#94473)

the previous constraint enforced that the destination type had to be
sentry region and the region name had to be null instead of enforcing:

if the destination type is sentry region then the region name must be
null

Author: joseph-sentry

migrations_lockfile.txt

@@ -11,7 +11,7 @@ feedback: 0001_squashed_0004_index_together
 
 flags: 0001_squashed_0004_add_flag_audit_log_provider_column
 
-hybridcloud: 0022_webhook_payload_update
+hybridcloud: 0023_correct_webhook_payload_constraint
 
 insights: 0002_backfill_team_starred
 

src/sentry/hybridcloud/migrations/0023_correct_webhook_payload_constraint.py

@@ -0,0 +1,43 @@
+# Generated by Django 5.2.1 on 2025-06-26 19:37
+
+from django.db import migrations, models
+
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("hybridcloud", "0022_webhook_payload_update"),
+    ]
+
+    operations = [
+        migrations.RemoveConstraint(
+            model_name="webhookpayload",
+            name="webhookpayload_region_name_not_null",
+        ),
+        migrations.AddConstraint(
+            model_name="webhookpayload",
+            constraint=models.CheckConstraint(
+                condition=models.Q(
+                    models.Q(("destination_type", "sentry_region"), _negated=True),
+                    ("region_name__isnull", False),
+                    _connector="OR",
+                ),
+                name="webhookpayload_region_name_not_null",
+            ),
+        ),
+    ]

src/sentry/hybridcloud/models/webhookpayload.py

@@ -81,8 +81,8 @@ class Meta:
 
         constraints = [
             models.CheckConstraint(
-                condition=Q(destination_type=DestinationType.SENTRY_REGION)
-                & Q(region_name__isnull=False),
+                condition=~Q(destination_type=DestinationType.SENTRY_REGION)
+                | Q(region_name__isnull=False),
                 name="webhookpayload_region_name_not_null",
             ),
         ]