chore(feedback): Cleanup flag: user-feedback-ui (#95195)

Feature is fully rolled out. We shouldn't guard anything on this flag
anymore.

Author: ryan953

static/app/components/sidebar/index.spec.tsx

@@ -32,7 +32,6 @@ const ALL_AVAILABLE_FEATURES = [
   'discover-query',
   'dashboards-basic',
   'dashboards-edit',
-  'user-feedback-ui',
   'session-replay-ui',
   'performance-view',
   'profiling',

static/app/components/sidebar/index.tsx

@@ -252,15 +252,13 @@ function Sidebar() {
   );
 
   const feedback = hasOrganization && (
-    <Feature features="user-feedback-ui" organization={organization}>
-      <SidebarItem
-        {...sidebarItemProps}
-        icon={<IconMegaphone />}
-        label={t('User Feedback')}
-        to={`/organizations/${organization.slug}/feedback/`}
-        id="feedback"
-      />
-    </Feature>
+    <SidebarItem
+      {...sidebarItemProps}
+      icon={<IconMegaphone />}
+      label={t('User Feedback')}
+      to={`/organizations/${organization.slug}/feedback/`}
+      id="feedback"
+    />
   );
 
   const alerts = hasOrganization && (

static/app/views/feedback/index.tsx

@@ -1,10 +1,6 @@
-import Feature from 'sentry/components/acl/feature';
 import AnalyticsArea from 'sentry/components/analyticsArea';
-import {Alert} from 'sentry/components/core/alert';
-import * as Layout from 'sentry/components/layouts/thirds';
 import NoProjectMessage from 'sentry/components/noProjectMessage';
 import Redirect from 'sentry/components/redirect';
-import {t} from 'sentry/locale';
 import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
 import useOrganization from 'sentry/utils/useOrganization';
 import {useRedirectNavV2Routes} from 'sentry/views/nav/useRedirectNavV2Routes';
@@ -26,24 +22,8 @@ export default function FeedbackContainer({children}: Props) {
   }
 
   return (
-    <Feature
-      features="user-feedback-ui"
-      organization={organization}
-      renderDisabled={NoAccess}
-    >
-      <AnalyticsArea name="feedback">
-        <NoProjectMessage organization={organization}>{children}</NoProjectMessage>
-      </AnalyticsArea>
-    </Feature>
-  );
-}
-
-function NoAccess() {
-  return (
-    <Layout.Page withPadding>
-      <Alert.Container>
-        <Alert type="warning">{t("You don't have access to this feature")}</Alert>
-      </Alert.Container>
-    </Layout.Page>
+    <AnalyticsArea name="feedback">
+      <NoProjectMessage organization={organization}>{children}</NoProjectMessage>
+    </AnalyticsArea>
   );
 }

static/app/views/nav/index.spec.tsx

@@ -31,7 +31,6 @@ const ALL_AVAILABLE_FEATURES = [
   'discover-query',
   'dashboards-basic',
   'dashboards-edit',
-  'user-feedback-ui',
   'session-replay-ui',
   'ourlogs-enabled',
   'performance-view',

static/app/views/projectDetail/projectQuickLinks.spec.tsx

@@ -35,7 +35,7 @@ describe('ProjectDetail > ProjectQuickLinks', function () {
 
     await userEvent.click(userFeedback);
     expect(router.push).toHaveBeenCalledWith({
-      pathname: '/organizations/org-slug/user-feedback/',
+      pathname: '/organizations/org-slug/feedback/',
       query: {project: '2'},
     });
 

static/app/views/projectDetail/projectQuickLinks.tsx

@@ -31,7 +31,6 @@ type Props = {
 };
 
 function ProjectQuickLinks({organization, project}: Props) {
-  const hasNewFeedback = organization.features.includes('user-feedback-ui');
   const domainView: DomainView | undefined = project
     ? platformToDomainView([project], [parseInt(project.id, 10)])
     : 'backend';
@@ -67,9 +66,7 @@ function ProjectQuickLinks({organization, project}: Props) {
     {
       title: t('User Feedback'),
       to: {
-        pathname: hasNewFeedback
-          ? `/organizations/${organization.slug}/feedback/`
-          : `/organizations/${organization.slug}/user-feedback/`,
+        pathname: `/organizations/${organization.slug}/feedback/`,
         query: {project: project?.id},
       },
     },