Skip to content

Commit 119d3f3

Browse files
authored
chore: Remove unneeded references to DeprecatedAsyncComponent (#95400)
Related to getsentry/frontend-tsc#2
1 parent 9bbc290 commit 119d3f3

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

static/app/components/externalIssues/externalIssueForm.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ export default function ExternalIssueForm({
157157
setIsDynamicallyRefetching(false);
158158
},
159159
error: (err: any) => {
160-
// This behavior comes from the DeprecatedAsyncComponent
161160
if (err?.responseText) {
162161
Sentry.addBreadcrumb({
163162
message: err.responseText,

static/app/components/externalIssues/ticketRuleModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,12 @@ export default function TicketRuleModal({
183183
integrationId: instance.integration,
184184
query: initialConfigQuery,
185185
}),
186-
existingData => (data ? data : existingData)
186+
(existingData: IntegrationIssueConfig | undefined) =>
187+
data ? data : existingData
187188
);
188189
setIsDynamicallyRefetching(false);
189190
},
190191
error: (err: any) => {
191-
// This behavior comes from the DeprecatedAsyncComponent
192192
if (err?.responseText) {
193193
Sentry.addBreadcrumb({
194194
message: err.responseText,

static/app/views/admin/installWizard/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {useApiQuery} from 'sentry/utils/queryClient';
1414
import type {Field} from 'sentry/views/admin/options';
1515
import {getForm, getOptionDefault, getOptionField} from 'sentry/views/admin/options';
1616

17-
export type InstallWizardProps = {
17+
type InstallWizardProps = {
1818
onConfigured: () => void;
1919
};
2020

static/app/views/app/index.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {GlobalFeedbackForm} from 'sentry/utils/useFeedbackForm';
3434
import {useHotkeys} from 'sentry/utils/useHotkeys';
3535
import {useLocation} from 'sentry/utils/useLocation';
3636
import {useUser} from 'sentry/utils/useUser';
37-
import type {InstallWizardProps} from 'sentry/views/admin/installWizard';
3837
import {AsyncSDKIntegrationContextProvider} from 'sentry/views/app/asyncSDKIntegrationProvider';
3938
import LastKnownRouteContextProvider from 'sentry/views/lastKnownRouteContextProvider';
4039
import {OrganizationContextProvider} from 'sentry/views/organizationContext';
@@ -44,10 +43,7 @@ type Props = {
4443
children: React.ReactNode;
4544
} & RouteComponentProps<{orgId?: string}>;
4645

47-
const InstallWizard = lazy(
48-
() => import('sentry/views/admin/installWizard')
49-
// TODO(TS): DeprecatedAsyncComponent prop types are doing something weird
50-
) as unknown as React.ComponentType<InstallWizardProps>;
46+
const InstallWizard = lazy(() => import('sentry/views/admin/installWizard'));
5147
const NewsletterConsent = lazy(() => import('sentry/views/newsletterConsent'));
5248
const BeaconConsent = lazy(() => import('sentry/views/beaconConsent'));
5349

0 commit comments

Comments
 (0)