Windows line-ending can potentially cause havoc when importing into Perforce

[yangskyboxlabs]

I don't think this is a bug-worthy issue per se, but is annoying enough that I wanted to raise some awareness of it.

There are some source files in the repo that use CRLF line ending, whilst the majority are LF. When the former is submitted into Perforce from a workspace that uses LineEnd: unix, p4 will preserve the CR on server (the intended behaviour is to normalize to LF for storage). These line endings will then materialize as CRCRLF in a Windows workspace, and Unreal will be very unhappy about it:

D:\h\[redacted]\Sync\Projects\[redacted]\Plugins\Sentry\Source\ThirdParty\Win64\Breakpad\include\sentry.h(1,1): error C4335: Mac file format detected: please convert the source file to either DOS or UNIX format
/**
^
[3/10] (Wall: 7.24s CPU: 2.86s) Compile [x64] Module.Sentry.3.cpp
D:\h\[redacted]\Sync\Projects\[redacted]\Plugins\Sentry\Source\Sentry\Private\Microsoft\MicrosoftSentrySubsystem.cpp(1,1): error C4335: Mac file format detected: please convert the source file to either DOS or UNIX format
// Copyright (c) 2025 Sentry. All Rights Reserved.
^
D:\h\[redacted]\Sync\Projects\[redacted]\Plugins\Sentry\Source\Sentry\Private\Microsoft\MicrosoftSentrySubsystem.h(1,1): error C4335: Mac file format detected: please convert the source file to either DOS or UNIX format
// Copyright (c) 2025 Sentry. All Rights Reserved.
^
D:\h\[redacted]\Sync\Projects\[redacted]\Plugins\Sentry\Source\ThirdParty\Win64\Breakpad\include\sentry.h(1,1): error C4335: Mac file format detected: please convert the source file to either DOS or UNIX format

Something to keep in mind for new sources that are added. I imagine dumping a source package into p4 is a very common scenario, although very, very rarely with a workspace configured for unix line ending.

[tustanivsky]

Thank you for bringing this up and for opening #969. While using unix line endings might not be the most common case on Windows it's definitely something we should support to prevent the errors you've mentioned above. We can also add automated checks to ensure that newly added source files have the correct line endings going forward.

[tustanivsky]

@yangskyboxlabs Line-ending issues should be resolved in #986. We've also added automation checks to help prevent them from reappearing in the future.