fix: Reporting SDK's name on Apple platforms (#2112)

* return success state

* Updated CHANGELOG.md

* set sdk name

* native options use bridge. and tests

* native options set name

* evil ''

* fixed test

Author: bitsandfoxes

package-dev/Plugins/iOS/SentryNativeBridge.m

@@ -46,6 +46,11 @@ int SentryNativeBridgeStartWithOptions(const void *options)
     return 1;
 }
 
+void SentryNativeBridgeSetSdkName()
+{
+    [PrivateSentrySDKOnly performSelector:@selector(setSdkName:) withObject:@"sentry.cocoa.unity"];
+}
+
 int SentryNativeBridgeCrashedLastRun() { return [SentrySDK crashedLastRun] ? 1 : 0; }
 
 void SentryNativeBridgeClose() { [SentrySDK close]; }

package-dev/Plugins/iOS/SentryNativeBridgeNoOp.m

@@ -8,6 +8,8 @@ void SentryNativeBridgeOptionsSetString(void *options, const char *name, const c
 void SentryNativeBridgeOptionsSetInt(void *options, const char *name, int32_t value) { }
 int SentryNativeBridgeStartWithOptions(void *options) { return 0; }
 
+void SentryNativeBridgeSetSdkName() { }
+
 int SentryNativeBridgeCrashedLastRun() { return 0; }
 
 void SentryNativeBridgeClose() { }

package-dev/Plugins/macOS/SentryNativeBridge.m

@@ -123,6 +123,11 @@ void SentryConfigureScope(void (^callback)(id))
 /*   - use [obj setValue:value forKey:@"prop"] instead of `obj.prop = value`   */
 /*******************************************************************************/
 
+void SentryNativeBridgeSetSdkName()
+{
+    [PrivateSentrySDKOnly performSelector:@selector(setSdkName:) withObject:@"sentry.cocoa.unity"];
+}
+
 int SentryNativeBridgeCrashedLastRun()
 {
     @try {

src/Sentry.Unity.iOS/SentryCocoaBridgeProxy.cs

@@ -82,6 +82,9 @@ public static bool Init(SentryUnityOptions options)
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeStartWithOptions")]
     private static extern int StartWithOptions(IntPtr options);
 
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeSetSdkName")]
+    public static extern int SetSdkName();
+
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeCrashedLastRun")]
     public static extern int CrashedLastRun();
 

src/Sentry.Unity.iOS/SentryNativeCocoa.cs

@@ -52,6 +52,8 @@ internal static void Configure(SentryUnityOptions options, ISentryUnityInfo sent
             options.ScopeObserver = new NativeScopeObserver("macOS", options);
         }
 
+        SentryCocoaBridgeProxy.SetSdkName(); // Since we're not building the SDK we have to overwrite the name here
+
         options.NativeContextWriter = new NativeContextWriter();
         options.EnableScopeSync = true;
         options.CrashedLastRun = () =>

test/Sentry.Unity.Editor.iOS.Tests/NativeOptionsTests.cs

@@ -87,6 +87,21 @@ public void CreateOptionsFile_NewSentryOptions_ContainsBaseOptions()
         File.Delete(testOptionsFileName);
     }
 
+    [Test]
+    public void CreateOptionsFile_NewSentryOptions_ContainsSdkNameSetting()
+    {
+        const string testOptionsFileName = "testOptions.m";
+
+        NativeOptions.CreateFile(testOptionsFileName, new SentryUnityOptions());
+
+        Assert.IsTrue(File.Exists(testOptionsFileName)); // Sanity check
+
+        var nativeOptions = File.ReadAllText(testOptionsFileName);
+        StringAssert.Contains("sentry.cocoa.unity", nativeOptions);
+
+        File.Delete(testOptionsFileName);
+    }
+
     [Test]
     public void CreateOptionsFile_FilterBadGatewayEnabled_AddsFiltering()
     {