fix: Added missing method to iOS noop-bridge (#1983)

Author: bitsandfoxes

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- When targeting iOS and disabling native support, the SDK no longer causes builds to fail with an `Undefined symbol: _SentryNativeBridgeIsEnabled` error. ([#1983](https://github.com/getsentry/sentry-unity/pull/1983))
+
 ### Dependencies
 
 - Bump Native SDK from v0.7.18 to v0.7.19 ([#1981](https://github.com/getsentry/sentry-unity/pull/1981))

package-dev/Plugins/iOS/SentryNativeBridgeNoOp.m

@@ -2,6 +2,7 @@
 
 // macOS only
 int SentryNativeBridgeLoadLibrary() { return 0; }
+int SentryNativeBridgeIsEnabled() { return 0; }
 void *_Nullable SentryNativeBridgeOptionsNew() { return nil; }
 void SentryNativeBridgeOptionsSetString(void *options, const char *name, const char *value) { }
 void SentryNativeBridgeOptionsSetInt(void *options, const char *name, int32_t value) { }

src/Sentry.Unity.iOS/NativeScopeObserver.cs

@@ -11,20 +11,20 @@ public override void AddBreadcrumbImpl(Breadcrumb breadcrumb)
         var level = GetBreadcrumbLevel(breadcrumb.Level);
         var timestamp = GetTimestamp(breadcrumb.Timestamp);
 
-        SentryCocoaBridgeProxy.SentryNativeBridgeAddBreadcrumb(timestamp, breadcrumb.Message, breadcrumb.Type, breadcrumb.Category, level);
+        SentryCocoaBridgeProxy.AddBreadcrumb(timestamp, breadcrumb.Message, breadcrumb.Type, breadcrumb.Category, level);
     }
 
     public override void SetExtraImpl(string key, string? value) =>
-        SentryCocoaBridgeProxy.SentryNativeBridgeSetExtra(key, value);
+        SentryCocoaBridgeProxy.SetExtra(key, value);
 
-    public override void SetTagImpl(string key, string value) => SentryCocoaBridgeProxy.SentryNativeBridgeSetTag(key, value);
+    public override void SetTagImpl(string key, string value) => SentryCocoaBridgeProxy.SetTag(key, value);
 
-    public override void UnsetTagImpl(string key) => SentryCocoaBridgeProxy.SentryNativeBridgeUnsetTag(key);
+    public override void UnsetTagImpl(string key) => SentryCocoaBridgeProxy.UnsetTag(key);
 
     public override void SetUserImpl(SentryUser user) =>
-        SentryCocoaBridgeProxy.SentryNativeBridgeSetUser(user.Email, user.Id, user.IpAddress, user.Username);
+        SentryCocoaBridgeProxy.SetUser(user.Email, user.Id, user.IpAddress, user.Username);
 
-    public override void UnsetUserImpl() => SentryCocoaBridgeProxy.SentryNativeBridgeUnsetUser();
+    public override void UnsetUserImpl() => SentryCocoaBridgeProxy.UnsetUser();
 
     internal static string GetTimestamp(DateTimeOffset timestamp) =>
         // "o": Using ISO 8601 to make sure the timestamp makes it to the bridge correctly.

src/Sentry.Unity.iOS/Properties/AssemblyInfo.cs

@@ -1,3 +1,4 @@
 using System.Runtime.CompilerServices;
 
 [assembly: InternalsVisibleTo("Sentry.Unity.iOS.Tests")]
+[assembly: InternalsVisibleTo("Sentry.Unity.Editor.iOS.Tests")]

src/Sentry.Unity.iOS/SentryCocoaBridgeProxy.cs

@@ -88,23 +88,23 @@ public static bool Init(SentryUnityOptions options)
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeClose")]
     public static extern void Close();
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeAddBreadcrumb(string timestamp, string? message, string? type, string? category, int level);
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeAddBreadcrumb")]
+    public static extern void AddBreadcrumb(string timestamp, string? message, string? type, string? category, int level);
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeSetExtra(string key, string? value);
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeSetExtra")]
+    public static extern void SetExtra(string key, string? value);
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeSetTag(string key, string value);
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeSetTag")]
+    public static extern void SetTag(string key, string value);
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeUnsetTag(string key);
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeUnsetTag")]
+    public static extern void UnsetTag(string key);
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeSetUser(string? email, string? userId, string? ipAddress, string? username);
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeSetUser")]
+    public static extern void SetUser(string? email, string? userId, string? ipAddress, string? username);
 
-    [DllImport("__Internal")]
-    public static extern void SentryNativeBridgeUnsetUser();
+    [DllImport("__Internal", EntryPoint = "SentryNativeBridgeUnsetUser")]
+    public static extern void UnsetUser();
 
     [DllImport("__Internal", EntryPoint = "SentryNativeBridgeGetInstallationId")]
     public static extern string GetInstallationId();

test/Sentry.Unity.Editor.iOS.Tests/Sentry.Unity.Editor.iOS.Tests.csproj

@@ -12,6 +12,7 @@
   <ItemGroup>
     <ProjectReference Include="../../src/sentry-dotnet/src/Sentry/Sentry.csproj" Private="false" />
     <ProjectReference Include="../../src/Sentry.Unity/Sentry.Unity.csproj" Private="false" />
+    <ProjectReference Include="../../src/Sentry.Unity.iOS/Sentry.Unity.iOS.csproj" Private="false" />
     <ProjectReference Include="../../src/Sentry.Unity.Editor/Sentry.Unity.Editor.csproj" Private="false" />
     <ProjectReference Include="../../src/Sentry.Unity.Editor.iOS/Sentry.Unity.Editor.iOS.csproj" Private="false" />
   </ItemGroup>

test/Sentry.Unity.Editor.iOS.Tests/SentryNativeBridgeTests.cs

@@ -0,0 +1,40 @@
+using System.Linq;
+using System.Reflection;
+using System.Runtime.InteropServices;
+using System.Text.RegularExpressions;
+using NUnit.Framework;
+using Sentry.Unity.iOS;
+
+namespace Sentry.Unity.Editor.iOS.Tests
+{
+    public class SentryNativeBridgeTests
+    {
+        [Test]
+        public void EntryPoints_ExistInNativeBridges()
+        {
+            var entryPoints = typeof(SentryCocoaBridgeProxy)
+                .GetMethods(BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Static)
+                .Where(method => method.GetCustomAttribute<DllImportAttribute>() != null)
+                .Select(method => method.GetCustomAttribute<DllImportAttribute>().EntryPoint)
+                .ToList();
+
+            Assert.That(entryPoints, Is.Not.Empty); // Sanity check
+
+            const string? bridgePath = "../../package-dev/Plugins/iOS/SentryNativeBridge.m";
+            const string? noOpBridgePath = "../../package-dev/Plugins/iOS/SentryNativeBridgeNoOp.m";
+
+            var bridgeContent = System.IO.File.ReadAllText(bridgePath);
+            var noOpBridgeContent = System.IO.File.ReadAllText(noOpBridgePath);
+
+            foreach (var entryPoint in entryPoints)
+            {
+                var pattern = $@"{entryPoint}\s*\(";
+
+                Assert.That(Regex.IsMatch(bridgeContent, pattern),
+                    $"Entry point '{entryPoint}' not found in {bridgePath}");
+                Assert.That(Regex.IsMatch(noOpBridgeContent, pattern),
+                    $"Entry point '{entryPoint}' not found in {noOpBridgePath}");
+            }
+        }
+    }
+}