review

Author: Litarnus

src/Serializer/EnvelopItems/AttachmentItem.php

@@ -8,7 +8,7 @@
 use Sentry\Event;
 use Sentry\Util\JSON;
 
-class AttachmentItem implements EnvelopeItemInterface
+class AttachmentItem
 {
     public static function toAttachmentItem(Attachment $attachment): ?string
     {
@@ -27,14 +27,4 @@ public static function toAttachmentItem(Attachment $attachment): ?string
 
         return \sprintf("%s\n%s", JSON::encode($header), $data);
     }
-
-    public static function toEnvelopeItem(Event $event): ?string
-    {
-        $result = [];
-        foreach ($event->getAttachments() as $attachment) {
-            $result[] = self::toAttachmentItem($attachment);
-        }
-
-        return implode("\n", $result);
-    }
 }

src/Serializer/PayloadSerializer.php

@@ -61,14 +61,18 @@ public function serialize(Event $event): string
         switch ($event->getType()) {
             case EventType::event():
                 $items[] = EventItem::toEnvelopeItem($event);
-                $items[] = AttachmentItem::toEnvelopeItem($event);
+                foreach ($event->getAttachments() as $attachment) {
+                    $items[] = AttachmentItem::toAttachmentItem($attachment);
+                }
                 break;
             case EventType::transaction():
                 $items[] = TransactionItem::toEnvelopeItem($event);
                 if ($event->getSdkMetadata('profile') !== null) {
                     $items[] = ProfileItem::toEnvelopeItem($event);
                 }
-                $items[] = AttachmentItem::toEnvelopeItem($event);
+                foreach ($event->getAttachments() as $attachment) {
+                    $items[] = AttachmentItem::toAttachmentItem($attachment);
+                }
                 break;
             case EventType::checkIn():
                 $items[] = CheckInItem::toEnvelopeItem($event);