From b38e89f67155f2caeccb4cb6484c4a668519f719 Mon Sep 17 00:00:00 2001 From: s1gr1d Date: Fri, 27 Jun 2025 12:28:34 +0200 Subject: [PATCH 1/2] fix(nuxt): Only add OTel alias in dev mode --- packages/nuxt/src/vite/utils.ts | 8 +++++++- packages/nuxt/test/vite/utils.test.ts | 16 ++++++++++++++-- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/packages/nuxt/src/vite/utils.ts b/packages/nuxt/src/vite/utils.ts index 53d4e57d16e3..758ea657818a 100644 --- a/packages/nuxt/src/vite/utils.ts +++ b/packages/nuxt/src/vite/utils.ts @@ -191,9 +191,15 @@ export function constructFunctionReExport(pathWithQuery: string, entryId: string * @see https://nuxt.com/docs/guide/concepts/esm#aliasing-libraries */ export function addOTelCommonJSImportAlias(nuxt: Nuxt): void { + if (nuxt.options.dev) { + return; + } + if (!nuxt.options.alias) { nuxt.options.alias = {}; } - nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js'; + if (!nuxt.options.alias['@opentelemetry/resources']) { + nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js'; + } } diff --git a/packages/nuxt/test/vite/utils.test.ts b/packages/nuxt/test/vite/utils.test.ts index 8bb77bc6e12b..c3aae0dade39 100644 --- a/packages/nuxt/test/vite/utils.test.ts +++ b/packages/nuxt/test/vite/utils.test.ts @@ -398,7 +398,7 @@ describe('addOTelCommonJSImportAlias', () => { }); }); - it('overwrites existing alias for @opentelemetry/resources if already present', () => { + it('does not override existing alias for @opentelemetry/resources', () => { const nuxtMock: Nuxt = { options: { alias: { @@ -410,7 +410,19 @@ describe('addOTelCommonJSImportAlias', () => { addOTelCommonJSImportAlias(nuxtMock); expect(nuxtMock.options.alias).toEqual({ - '@opentelemetry/resources': '@opentelemetry/resources/build/src/index.js', + '@opentelemetry/resources': 'some-other-path', }); }); + + it('does not add alias in development mode', () => { + const nuxtMock: Nuxt = { + options: { + dev: true, + }, + } as unknown as Nuxt; + + addOTelCommonJSImportAlias(nuxtMock); + + expect(nuxtMock.options.alias).toBeUndefined(); + }); }); From de91821711a89a4ca4e4290c564cdbf0d7973659 Mon Sep 17 00:00:00 2001 From: s1gr1d Date: Fri, 27 Jun 2025 12:43:01 +0200 Subject: [PATCH 2/2] fix conditional --- packages/nuxt/src/vite/utils.ts | 2 +- packages/nuxt/test/vite/utils.test.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/nuxt/src/vite/utils.ts b/packages/nuxt/src/vite/utils.ts index 758ea657818a..fc55ebf412c2 100644 --- a/packages/nuxt/src/vite/utils.ts +++ b/packages/nuxt/src/vite/utils.ts @@ -191,7 +191,7 @@ export function constructFunctionReExport(pathWithQuery: string, entryId: string * @see https://nuxt.com/docs/guide/concepts/esm#aliasing-libraries */ export function addOTelCommonJSImportAlias(nuxt: Nuxt): void { - if (nuxt.options.dev) { + if (!nuxt.options.dev) { return; } diff --git a/packages/nuxt/test/vite/utils.test.ts b/packages/nuxt/test/vite/utils.test.ts index c3aae0dade39..6380d2d6a0c7 100644 --- a/packages/nuxt/test/vite/utils.test.ts +++ b/packages/nuxt/test/vite/utils.test.ts @@ -371,7 +371,7 @@ export { foo_sentryWrapped as foo }; describe('addOTelCommonJSImportAlias', () => { it('adds alias for @opentelemetry/resources when options.alias does not exist', () => { const nuxtMock: Nuxt = { - options: {}, + options: { dev: true }, } as unknown as Nuxt; addOTelCommonJSImportAlias(nuxtMock); @@ -384,6 +384,7 @@ describe('addOTelCommonJSImportAlias', () => { it('adds alias for @opentelemetry/resources when options.alias already exists', () => { const nuxtMock: Nuxt = { options: { + dev: true, alias: { 'existing-alias': 'some-path', }, @@ -401,6 +402,7 @@ describe('addOTelCommonJSImportAlias', () => { it('does not override existing alias for @opentelemetry/resources', () => { const nuxtMock: Nuxt = { options: { + dev: true, alias: { '@opentelemetry/resources': 'some-other-path', }, @@ -414,11 +416,9 @@ describe('addOTelCommonJSImportAlias', () => { }); }); - it('does not add alias in development mode', () => { + it('does not add alias when not development mode', () => { const nuxtMock: Nuxt = { - options: { - dev: true, - }, + options: {}, } as unknown as Nuxt; addOTelCommonJSImportAlias(nuxtMock);