Skip to content

Commit b8dedcb

Browse files
committed
fix integration tests
1 parent 127effd commit b8dedcb

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/element-timing/template.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
</head>
66
<body>
77
<!-- eagerly loaded image (image-paint) with fast load time -->
8-
<img src="https://sentry-test-site.example/path/to/image-fast.png" elementtiming="image-fast" />
8+
<img src="https://sentry-test-site.example/path/to/image-fast.png" elementtiming="image-fast" id="image-fast-id"/>
99

1010
<!-- eagerly rendered text (text-paint) -->
11-
<p elementtiming="text1">
11+
<p elementtiming="text1" id="text1-id">
1212
This is some text content
1313
<pan>with another nested span</pan>
1414
<small>and a small text</small>

dev-packages/browser-integration-tests/suites/tracing/metrics/element-timing/test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ sentryTest(
3636
'sentry.origin': 'auto.ui.browser.elementtiming',
3737
'sentry.source': 'component',
3838
'sentry.span_start_time_source': 'load-time',
39+
'element.id': 'image-fast-id',
3940
'element.identifier': 'image-fast',
4041
'element.type': 'img',
4142
'element.size': '600x179',
@@ -64,6 +65,7 @@ sentryTest(
6465
'sentry.origin': 'auto.ui.browser.elementtiming',
6566
'sentry.source': 'component',
6667
'sentry.span_start_time_source': 'render-time',
68+
'element.id': 'text1-id',
6769
'element.identifier': 'text1',
6870
'element.type': 'p',
6971
'element.render_time': expect.any(Number),
@@ -91,6 +93,7 @@ sentryTest(
9193
const imageSlowSpan = elementTimingSpans?.find(({ data }) => data?.['element.identifier'] === 'image-slow');
9294
expect(imageSlowSpan).toBeDefined();
9395
expect(imageSlowSpan?.data).toEqual({
96+
'element.id': '',
9497
'element.identifier': 'image-slow',
9598
'element.type': 'img',
9699
'element.size': '600x179',
@@ -118,6 +121,7 @@ sentryTest(
118121
const lazyImageSpan = elementTimingSpans?.find(({ data }) => data?.['element.identifier'] === 'lazy-image');
119122
expect(lazyImageSpan).toBeDefined();
120123
expect(lazyImageSpan?.data).toEqual({
124+
'element.id': '',
121125
'element.identifier': 'lazy-image',
122126
'element.type': 'img',
123127
'element.size': '600x179',
@@ -144,6 +148,7 @@ sentryTest(
144148
// Check lazy-text span
145149
const lazyTextSpan = elementTimingSpans?.find(({ data }) => data?.['element.identifier'] === 'lazy-text');
146150
expect(lazyTextSpan?.data).toMatchObject({
151+
'element.id': '',
147152
'element.identifier': 'lazy-text',
148153
'element.type': 'p',
149154
'sentry.transaction_name': '/index.html',

0 commit comments

Comments
 (0)