Skip to content

Commit 46eb462

Browse files
committed
review comments
1 parent cf6992f commit 46eb462

File tree

4 files changed

+3
-4
lines changed
  • dev-packages/browser-integration-tests/suites/integrations/featureFlags
  • packages/browser/src

4 files changed

+3
-4
lines changed

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/basic/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ sentryTest('Basic test with eviction, update, and no async tasks', async ({ getL
2222
const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
2323
await page.goto(url);
2424

25-
await page.waitForFunction(bufferSize => {
25+
await page.evaluate(bufferSize => {
2626
const ldClient = (window as any).initializeLD();
2727
for (let i = 1; i <= bufferSize; i++) {
2828
ldClient.variation(`feat${i}`, false);

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
2525
const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
2626
const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
2727

28-
await page.waitForFunction(() => {
28+
await page.evaluate(() => {
2929
const Sentry = (window as any).Sentry;
3030
const errorButton = document.querySelector('#error') as HTMLButtonElement;
3131
const ldClient = (window as any).initializeLD();

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/withScope/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
2525
const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
2626
const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
2727

28-
await page.waitForFunction(() => {
28+
await page.evaluate(() => {
2929
const Sentry = (window as any).Sentry;
3030
const errorButton = document.querySelector('#error') as HTMLButtonElement;
3131
const client = (window as any).initialize();

packages/browser/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,5 @@ export type { Span } from '@sentry/core';
6868
export { makeBrowserOfflineTransport } from './transports/offline';
6969
export { browserProfilingIntegration } from './profiling/integration';
7070
export { spotlightBrowserIntegration } from './integrations/spotlight';
71-
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
7271
export { launchDarklyIntegration, buildLaunchDarklyFlagUsedHandler } from './integrations/featureFlags/launchdarkly';
7372
export { openFeatureIntegration, OpenFeatureIntegrationHook } from './integrations/featureFlags/openfeature';

0 commit comments

Comments
 (0)