Skip to content

Commit 0a2cff4

Browse files
committed
better comments and name
1 parent 3ad8cc2 commit 0a2cff4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/opentelemetry/src/spanExporter.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ export class SentrySpanExporter {
155155
}
156156
}
157157
// Cancel a pending debounced flush, if there is one
158+
// This can be relevant if we directly export, circumventing the debounce
159+
// in that case, we want to cancel any pending debounced flush
158160
this._debouncedFlush.cancel();
159161
}
160162

@@ -222,15 +224,15 @@ export class SentrySpanExporter {
222224
}
223225

224226
/** Check if a node is a completed root node or a node whose parent has already been sent */
225-
private _nodeIsCompletedRootNode(node: SpanNode): node is SpanNodeCompleted {
227+
private _nodeIsCompletedRootNodeOrHasSentParent(node: SpanNode): node is SpanNodeCompleted {
226228
return !!node.span && (!node.parentNode || this._sentSpans.has(node.parentNode.id));
227229
}
228230

229231
/** Get all completed root nodes from a list of nodes */
230232
private _getCompletedRootNodes(nodes: SpanNode[]): SpanNodeCompleted[] {
231233
// TODO: We should be able to remove the explicit `node is SpanNodeCompleted` type guard
232234
// once we stop supporting TS < 5.5
233-
return nodes.filter((node): node is SpanNodeCompleted => this._nodeIsCompletedRootNode(node));
235+
return nodes.filter((node): node is SpanNodeCompleted => this._nodeIsCompletedRootNodeOrHasSentParent(node));
234236
}
235237
}
236238

0 commit comments

Comments
 (0)