From ad483799efb443b4be0bc33e5c4a066563a8b2d5 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 13 Jan 2025 19:00:30 +0100 Subject: [PATCH 1/2] fix(webpack): Ensure process exits when done --- packages/bundler-plugin-core/src/index.ts | 8 ++++++-- packages/webpack-plugin/src/index.ts | 11 ++++++++++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/packages/bundler-plugin-core/src/index.ts b/packages/bundler-plugin-core/src/index.ts index dc7006dc..e8eb3897 100644 --- a/packages/bundler-plugin-core/src/index.ts +++ b/packages/bundler-plugin-core/src/index.ts @@ -33,7 +33,10 @@ interface SentryUnpluginFactoryOptions { componentNameAnnotatePlugin?: (ignoredComponents?: string[]) => UnpluginOptions; moduleMetadataInjectionPlugin: (injectionCode: string) => UnpluginOptions; debugIdInjectionPlugin: (logger: Logger) => UnpluginOptions; - debugIdUploadPlugin: (upload: (buildArtifacts: string[]) => Promise) => UnpluginOptions; + debugIdUploadPlugin: ( + upload: (buildArtifacts: string[]) => Promise, + logger: Logger + ) => UnpluginOptions; bundleSizeOptimizationsPlugin: (buildFlags: SentrySDKBuildFlags) => UnpluginOptions; } @@ -408,7 +411,8 @@ export function sentryUnpluginFactory({ vcsRemote: options.release.vcsRemote, headers: options.headers, }, - }) + }), + logger ) ); } diff --git a/packages/webpack-plugin/src/index.ts b/packages/webpack-plugin/src/index.ts index f215630c..28db8ae0 100644 --- a/packages/webpack-plugin/src/index.ts +++ b/packages/webpack-plugin/src/index.ts @@ -5,6 +5,7 @@ import { stringToUUID, SentrySDKBuildFlags, createComponentNameAnnotateHooks, + Logger, } from "@sentry/bundler-plugin-core"; import * as path from "path"; import { UnpluginOptions } from "unplugin"; @@ -117,7 +118,8 @@ function webpackDebugIdInjectionPlugin(): UnpluginOptions { } function webpackDebugIdUploadPlugin( - upload: (buildArtifacts: string[]) => Promise + upload: (buildArtifacts: string[]) => Promise, + logger: Logger ): UnpluginOptions { const pluginName = "sentry-webpack-debug-id-upload-plugin"; return { @@ -133,6 +135,13 @@ function webpackDebugIdUploadPlugin( callback(); }); }); + + compiler.hooks.done.tap(pluginName, () => { + setTimeout(() => { + logger.debug("Exiting process after debug file upload"); + process.exit(0); + }); + }); }, }; } From c82a4d49bc953ccf6d05b0e49877cb68dbe76d44 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 13 Jan 2025 19:05:06 +0100 Subject: [PATCH 2/2] in prod --- packages/webpack-plugin/src/index.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/webpack-plugin/src/index.ts b/packages/webpack-plugin/src/index.ts index 28db8ae0..0389cc1c 100644 --- a/packages/webpack-plugin/src/index.ts +++ b/packages/webpack-plugin/src/index.ts @@ -136,12 +136,14 @@ function webpackDebugIdUploadPlugin( }); }); - compiler.hooks.done.tap(pluginName, () => { - setTimeout(() => { - logger.debug("Exiting process after debug file upload"); - process.exit(0); + if (compiler.options.mode === "production") { + compiler.hooks.done.tap(pluginName, () => { + setTimeout(() => { + logger.debug("Exiting process after debug file upload"); + process.exit(0); + }); }); - }); + } }, }; }