From 9d93d38c0274c67807543bf89fd873d61b44de90 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Mon, 3 Jun 2024 10:37:54 +0200 Subject: [PATCH 1/2] what was I smoking --- packages/esbuild-plugin/src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/esbuild-plugin/src/index.ts b/packages/esbuild-plugin/src/index.ts index 37f68e35..c6a565fc 100644 --- a/packages/esbuild-plugin/src/index.ts +++ b/packages/esbuild-plugin/src/index.ts @@ -51,9 +51,9 @@ function esbuildDebugIdInjectionPlugin(logger: Logger): UnpluginOptions { esbuild: { setup({ initialOptions, onLoad, onResolve }) { - if (initialOptions.bundle) { + if (!initialOptions.bundle) { logger.warn( - "Esbuild's `bundle: true` option is currently not supported! Esbuild will probably crash now. Sorry about that. If you need to upload sourcemaps with the `bundle` option, it is recommended to use Sentry CLI instead: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/" + "The Sentry esbuild plugin only supports esbuild with `bundle: true` being set in the esbuild build options! Esbuild will probably crash now. Sorry about that. If you need to upload sourcemaps without `bundle: true`, it is recommended to use Sentry CLI instead: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/" ); } From 88ef39897ea9fe1644d2e40d9f26d303648a98a2 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Mon, 3 Jun 2024 11:04:08 +0200 Subject: [PATCH 2/2] Update packages/esbuild-plugin/src/index.ts Co-authored-by: Francesco Novy --- packages/esbuild-plugin/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/esbuild-plugin/src/index.ts b/packages/esbuild-plugin/src/index.ts index c6a565fc..598b57eb 100644 --- a/packages/esbuild-plugin/src/index.ts +++ b/packages/esbuild-plugin/src/index.ts @@ -53,7 +53,7 @@ function esbuildDebugIdInjectionPlugin(logger: Logger): UnpluginOptions { setup({ initialOptions, onLoad, onResolve }) { if (!initialOptions.bundle) { logger.warn( - "The Sentry esbuild plugin only supports esbuild with `bundle: true` being set in the esbuild build options! Esbuild will probably crash now. Sorry about that. If you need to upload sourcemaps without `bundle: true`, it is recommended to use Sentry CLI instead: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/" + "The Sentry esbuild plugin only supports esbuild with `bundle: true` being set in the esbuild build options. Esbuild will probably crash now. Sorry about that. If you need to upload sourcemaps without `bundle: true`, it is recommended to use Sentry CLI instead: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/" ); }