From 55284b699d62b512e3093627e378df9187741a67 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 31 May 2024 14:21:30 +0200 Subject: [PATCH 1/2] feat: Allow passing of meta-framework as telemetry data --- packages/bundler-plugin-core/src/options-mapping.ts | 5 +++++ packages/bundler-plugin-core/src/sentry/telemetry.ts | 2 ++ packages/bundler-plugin-core/src/types.ts | 10 ++++++++++ 3 files changed, 17 insertions(+) diff --git a/packages/bundler-plugin-core/src/options-mapping.ts b/packages/bundler-plugin-core/src/options-mapping.ts index 32306c8d..9fd717e2 100644 --- a/packages/bundler-plugin-core/src/options-mapping.ts +++ b/packages/bundler-plugin-core/src/options-mapping.ts @@ -29,6 +29,11 @@ export function normalizeUserOptions(userOptions: UserOptions) { }, bundleSizeOptimizations: userOptions.bundleSizeOptimizations, reactComponentAnnotation: userOptions.reactComponentAnnotation, + _metaOptions: { + telemetry: { + metaFramework: userOptions._metaOptions?.telemetry?.metaFramework, + }, + }, _experiments: userOptions._experiments ?? {}, }; diff --git a/packages/bundler-plugin-core/src/sentry/telemetry.ts b/packages/bundler-plugin-core/src/sentry/telemetry.ts index d011b13c..fc5064f1 100644 --- a/packages/bundler-plugin-core/src/sentry/telemetry.ts +++ b/packages/bundler-plugin-core/src/sentry/telemetry.ts @@ -95,6 +95,8 @@ export function setTelemetryDataOnHub(options: NormalizedOptions, hub: Hub, bund hub.setTag("node", process.version); hub.setTag("platform", process.platform); + hub.setTag("meta-framework", options._metaOptions.telemetry.metaFramework ?? "none"); + hub.setTags({ organization: org, project, diff --git a/packages/bundler-plugin-core/src/types.ts b/packages/bundler-plugin-core/src/types.ts index 6419c074..3dae57c4 100644 --- a/packages/bundler-plugin-core/src/types.ts +++ b/packages/bundler-plugin-core/src/types.ts @@ -337,6 +337,16 @@ export interface Options { * Example value: `[sentry-webpack-plugin (client)]` */ loggerPrefixOverride?: string; + + /** + * Arbitrary telemetry items. + */ + telemetry?: { + /** + * The meta framework using the plugin. + */ + metaFramework?: string; + }; }; } From a6f52a2f01c1902877590278516c35b7cec96423 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 31 May 2024 14:40:38 +0200 Subject: [PATCH 2/2] test --- .../bundler-plugin-core/test/option-mappings.test.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/bundler-plugin-core/test/option-mappings.test.ts b/packages/bundler-plugin-core/test/option-mappings.test.ts index d9386cbb..54907571 100644 --- a/packages/bundler-plugin-core/test/option-mappings.test.ts +++ b/packages/bundler-plugin-core/test/option-mappings.test.ts @@ -27,6 +27,11 @@ describe("normalizeUserOptions()", () => { silent: false, telemetry: true, _experiments: {}, + _metaOptions: { + telemetry: { + metaFramework: undefined, + }, + }, url: "https://sentry.io", }); }); @@ -73,6 +78,11 @@ describe("normalizeUserOptions()", () => { silent: false, telemetry: true, _experiments: {}, + _metaOptions: { + telemetry: { + metaFramework: undefined, + }, + }, url: "https://sentry.io", }); });