Assume http.client for span op if not a root span (#4257)

* Assume http.client for span op if not a root span

* changelog

Author: adinauer

CHANGELOG.md

@@ -19,6 +19,7 @@
 - Pass OpenTelemetry span attributes into TracesSampler callback ([#4253](https://github.com/getsentry/sentry-java/pull/4253))
   - `SamplingContext` now has a `getAttribute` method that grants access to OpenTelemetry span attributes via their String key (e.g. `http.request.method`)
 - Fix AbstractMethodError when using SentryTraced for Jetpack Compose ([#4255](https://github.com/getsentry/sentry-java/pull/4255))
+- Assume `http.client` for span `op` if not a root span ([#4257](https://github.com/getsentry/sentry-java/pull/4257))
 - Avoid unnecessary copies when using `CopyOnWriteArrayList` ([#4247](https://github.com/getsentry/sentry-java/pull/4247))
   - This affects in particular `SentryTracer.getLatestActiveSpan` which would have previously copied all child span references. This may have caused `OutOfMemoryError` on certain devices due to high frequency of calling the method.
 

sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java

@@ -18,23 +18,16 @@ public final class SpanDescriptionExtractor {
   @SuppressWarnings("deprecation")
   public @NotNull OtelSpanInfo extractSpanInfo(
       final @NotNull SpanData otelSpan, final @Nullable IOtelSpanWrapper sentrySpan) {
-    if (!isInternalSpanKind(otelSpan)) {
-      final @NotNull Attributes attributes = otelSpan.getAttributes();
-
-      final @Nullable String httpMethod = attributes.get(HttpAttributes.HTTP_REQUEST_METHOD);
-      if (httpMethod != null) {
-        return descriptionForHttpMethod(otelSpan, httpMethod);
-      }
+    final @NotNull Attributes attributes = otelSpan.getAttributes();
 
-      final @Nullable String httpRequestMethod = attributes.get(HttpAttributes.HTTP_REQUEST_METHOD);
-      if (httpRequestMethod != null) {
-        return descriptionForHttpMethod(otelSpan, httpRequestMethod);
-      }
+    final @Nullable String httpMethod = attributes.get(HttpAttributes.HTTP_REQUEST_METHOD);
+    if (httpMethod != null) {
+      return descriptionForHttpMethod(otelSpan, httpMethod);
+    }
 
-      final @Nullable String dbSystem = attributes.get(DbIncubatingAttributes.DB_SYSTEM);
-      if (dbSystem != null) {
-        return descriptionForDbSystem(otelSpan);
-      }
+    final @Nullable String dbSystem = attributes.get(DbIncubatingAttributes.DB_SYSTEM);
+    if (dbSystem != null) {
+      return descriptionForDbSystem(otelSpan);
     }
 
     final @NotNull String name = otelSpan.getName();
@@ -44,10 +37,6 @@ public final class SpanDescriptionExtractor {
     return new OtelSpanInfo(name, description, TransactionNameSource.CUSTOM);
   }
 
-  private boolean isInternalSpanKind(final @NotNull SpanData otelSpan) {
-    return SpanKind.INTERNAL.equals(otelSpan.getKind());
-  }
-
   @SuppressWarnings("deprecation")
   private OtelSpanInfo descriptionForHttpMethod(
       final @NotNull SpanData otelSpan, final @NotNull String httpMethod) {
@@ -60,6 +49,12 @@ private OtelSpanInfo descriptionForHttpMethod(
       opBuilder.append(".client");
     } else if (SpanKind.SERVER.equals(kind)) {
       opBuilder.append(".server");
+    } else {
+      // we cannot be certain that a root span is a server span as it might simply be a client span
+      // without parent
+      if (!isRootSpan(otelSpan)) {
+        opBuilder.append(".client");
+      }
     }
     final @Nullable String httpTarget = attributes.get(HttpIncubatingAttributes.HTTP_TARGET);
     final @Nullable String httpRoute = attributes.get(HttpAttributes.HTTP_ROUTE);
@@ -92,6 +87,10 @@ private OtelSpanInfo descriptionForHttpMethod(
     return new OtelSpanInfo(op, description, transactionNameSource);
   }
 
+  private static boolean isRootSpan(SpanData otelSpan) {
+    return !otelSpan.getParentSpanContext().isValid() || otelSpan.getParentSpanContext().isRemote();
+  }
+
   @SuppressWarnings("deprecation")
   private OtelSpanInfo descriptionForDbSystem(final @NotNull SpanData otelSpan) {
     final @NotNull Attributes attributes = otelSpan.getAttributes();