Skip to content

Commit 992547e

Browse files
huynhsontungjamescrosswellbruno-garcia
authored
fix: MSBuild target produces incorrect release name (#4015)
* fix: msbuild target produces incorrect release name * Update CHANGELOG.md --------- Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com> Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
1 parent 641e44f commit 992547e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixes
66

7+
- Single quotes added to the release name when using MS Build to create Sentry releases on Windows ([#4015](https://github.com/getsentry/sentry-dotnet/pull/4015))
78
- Target `net9.0` on Sentry.Google.Cloud.Functions to avoid conflict with Sentry.AspNetCore ([#4039](https://github.com/getsentry/sentry-dotnet/pull/4039))
89
- Changed default value for `SentryOptions.EnableAppHangTrackingV2` to `false` ([#4042](https://github.com/getsentry/sentry-dotnet/pull/4042))
910

src/Sentry/buildTransitive/Sentry.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@
333333
Condition="'$(SentryCLI)' != '' and '$(SentryCreateRelease)' == 'true'">
334334
<Message Importance="High" Text="Creating Sentry Release: $(_SentryRelease)" />
335335
<Exec
336-
Command="$(SentryCLIBaseCommand) releases new '$(_SentryRelease)' $(SentryReleaseOptions)"
336+
Command="$(SentryCLIBaseCommand) releases new $(_SentryRelease) $(SentryReleaseOptions)"
337337
IgnoreExitCode="true" ContinueOnError="WarnAndContinue">
338338
<Output TaskParameter="ExitCode" PropertyName="_SentryCLIExitCode" />
339339
</Exec>
@@ -344,7 +344,7 @@
344344
Condition="'$(SentryCLI)' != '' and '$(SentrySetCommits)' == 'true'">
345345
<Message Importance="High" Text="Setting Sentry commits" />
346346
<Exec
347-
Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) '$(_SentryRelease)' $(SentryReleaseOptions)"
347+
Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) $(_SentryRelease) $(SentryReleaseOptions)"
348348
IgnoreExitCode="true" ContinueOnError="WarnAndContinue">
349349
<Output TaskParameter="ExitCode" PropertyName="_SentryCLIExitCode" />
350350
</Exec>

0 commit comments

Comments
 (0)