Skip to content

Commit d3193f5

Browse files
saifmodeimatwawana
andauthored
Fix wrong URL in link for sampling.mdx (#5279)
* Fix wrong URL in link for sampling.mdx The link to the "Connecting Services" page was for the JavaScript docs, not the Python docs. * updated link to platform link for common connect services page * add missing slash * added platform sections for connecting services links Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> Co-authored-by: Isabel Matwawana <isabel@matwawana.com>
1 parent 803ba6a commit d3193f5

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

src/platforms/common/configuration/sampling.mdx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,19 @@ When using custom instrumentation to create a transaction, you can add data to t
104104

105105
## Inheritance
106106

107-
<!-- TODO: the link in the paragraph below is intentionally hard-coded to point at JS, since for now that's where the information lives -->
107+
Whatever a transaction's sampling decision, that decision will be passed to its child spans and from there to any transactions they subsequently cause in other services.
108108

109-
Whatever a transaction's sampling decision, that decision will be passed to its child spans and from there to any transactions they subsequently cause in other services. (See [Connecting Services](/platforms/javascript/performance/) for more about how that propagation is done.)
109+
<PlatformSection notSupported={["javascript.cordova", "php"]}>
110+
111+
(See <PlatformLink to="/performance/connect-services/">Connecting Services</PlatformLink> for more about how that propagation is done.)
112+
113+
</PlatformSection>
114+
115+
<PlatformSection supported={["php.laravel"]}>
116+
117+
(See [Connecting Services](/platforms/php/guides/laravel/performance/connect-services/) for more about how that propagation is done.)
118+
119+
</PlatformSection>
110120

111121
If the transaction currently being created is one of those subsequent transactions (in other words, if it has a parent transaction), the upstream (parent) sampling decision will always be included in the sampling context data, so that your <PlatformIdentifier name="traces-sampler" /> can choose whether and when to inherit that decision. (In most cases, inheritance is the right choice, to avoid partial traces.)
112122

0 commit comments

Comments
 (0)