ref(ts): Marginally improve types in sourceNodes apis (#7328)

Author: evanpurkhiser

src/gatsby/sourceNodes/appRegistryNodes.ts

@@ -1,6 +1,11 @@
+import {SourceNodesArgs} from 'gatsby';
+
 import getAppRegistry from '../utils/appRegistry';
 
-export const sourceAppRegistryNodes = async ({actions, createContentDigest}) => {
+export const sourceAppRegistryNodes = async ({
+  actions,
+  createContentDigest,
+}: SourceNodesArgs) => {
   const {createNode} = actions;
 
   const appRegistry = await getAppRegistry();

src/gatsby/sourceNodes/awsLambdLayerRegistryNodes.ts

@@ -1,9 +1,11 @@
+import {SourceNodesArgs} from 'gatsby';
+
 import awsLambdaRegistry from '../utils/awsLambdaLayerRegistry';
 
 export const sourceAwsLambdaLayerRegistryNodes = async ({
   actions,
   createContentDigest,
-}) => {
+}: SourceNodesArgs) => {
   const {createNode} = actions;
 
   const layerMap = await awsLambdaRegistry.getLayerMap();

src/gatsby/sourceNodes/index.ts

@@ -1,17 +1,19 @@
+import {GatsbyNode} from 'gatsby';
+
 import {sourceAppRegistryNodes} from './appRegistryNodes';
 import {sourceAwsLambdaLayerRegistryNodes} from './awsLambdLayerRegistryNodes';
 import {sourcePackageRegistryNodes} from './packageRegistryNodes';
 import {sourcePlatformNodes} from './platformNodes';
 import {relayMetricsNodes} from './relayMetricsNodes';
 import {piiFieldsNodes} from './relayPiiNodes';
 
-async function main(params) {
+const sourceNodes: GatsbyNode['sourceNodes'] = async params => {
   relayMetricsNodes(params);
   piiFieldsNodes(params);
   await sourcePlatformNodes(params);
   await sourcePackageRegistryNodes(params);
   await sourceAppRegistryNodes(params);
   await sourceAwsLambdaLayerRegistryNodes(params);
-}
+};
 
-export default main;
+export default sourceNodes;

src/gatsby/sourceNodes/packageRegistryNodes.ts

@@ -1,6 +1,11 @@
+import {SourceNodesArgs} from 'gatsby';
+
 import getPackageRegistry from '../utils/packageRegistry';
 
-export const sourcePackageRegistryNodes = async ({actions, createContentDigest}) => {
+export const sourcePackageRegistryNodes = async ({
+  actions,
+  createContentDigest,
+}: SourceNodesArgs) => {
   const {createNode} = actions;
 
   const packageRegistry = await getPackageRegistry();

src/gatsby/sourceNodes/platformNodes.ts

@@ -1,11 +1,13 @@
+import {SourceNodesArgs} from 'gatsby';
+
 import PlatformRegistry from '../../shared/platformRegistry';
 
 export const sourcePlatformNodes = async ({
   actions,
   reporter,
   createNodeId,
   createContentDigest,
-}) => {
+}: SourceNodesArgs) => {
   const {createNode} = actions;
 
   const platformRegistry = new PlatformRegistry();

src/gatsby/sourceNodes/relayMetricsNodes.ts

@@ -1,12 +1,19 @@
+import {Node, SourceNodesArgs} from 'gatsby';
+
 import metrics from '../../data/relay_metrics.json';
 
-export const relayMetricsNodes = ({actions, createNodeId, createContentDigest}) => {
+export const relayMetricsNodes = ({
+  actions,
+  createNodeId,
+  createContentDigest,
+}: SourceNodesArgs) => {
   const {createNode, createParentChildLink} = actions;
 
   metrics.forEach(metric => {
-    const metricNode = {
+    const metricNode: Node = {
       ...metric,
       id: createNodeId(metric.name),
+      // @ts-expect-error TODO(epurkhiser): Understand what additional properties we need to add
       internal: {
         type: 'RelayMetric',
         contentDigest: createContentDigest(metric),
@@ -15,9 +22,10 @@ export const relayMetricsNodes = ({actions, createNodeId, createContentDigest})
 
     createNode(metricNode);
 
-    const descriptionNode = {
+    const descriptionNode: Node = {
       id: createNodeId(metric.name + '_description'),
       parent: metricNode.id,
+      // @ts-expect-error TODO(epurkhiser): Understand what additional properties we need to add
       internal: {
         content: metric.description,
         contentDigest: createContentDigest(metric.description),

src/gatsby/sourceNodes/relayPiiNodes.ts

@@ -3,14 +3,25 @@
 import fs from 'fs';
 import path from 'path';
 
-export const piiFieldsNodes = ({actions, createNodeId, createContentDigest}) => {
+import {SourceNodesArgs} from 'gatsby';
+
+interface PiiField {
+  additional_properties: string;
+  path: string;
+}
+
+export const piiFieldsNodes = ({
+  actions,
+  createNodeId,
+  createContentDigest,
+}: SourceNodesArgs) => {
   const {createNode} = actions;
 
   const data = fs.readFileSync(
     path.join(__dirname, '..', '..', 'data', 'relay_event_pii.json'),
     'utf-8'
   );
-  const fields = JSON.parse(data);
+  const fields: PiiField[] = JSON.parse(data);
 
   fields.forEach((field, index) => {
     const fieldNode = {