Skip to content

flutter v9: update snippets #13496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

flutter v9: update snippets #13496

wants to merge 25 commits into from

Conversation

buenaflor
Copy link
Contributor

Closes getsentry/sentry-dart#2702

Do not merge until Flutter v9 is GA

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 0:38am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 0:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 14, 2025 0:38am

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 393 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.19MB -387 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json -126 bytes 395.33kB -0.03%
../app/platform-redirect/page.js.nft.json -126 bytes 395.25kB -0.03%
../app/sitemap.xml/route.js.nft.json -126 bytes 393.22kB -0.03%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/fLjTNMcOwifTp6oDrFo6m/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/fLjTNMcOwifTp6oDrFo6m/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6GgbFRf7yFFwYLio8lK6S/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/6GgbFRf7yFFwYLio8lK6S/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@buenaflor buenaflor marked this pull request as ready for review April 24, 2025 14:47
coolguyzone
coolguyzone reviewed May 1, 2025
View reviewed changes
coolguyzone
coolguyzone approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd also recommend having a platform eng double-check all the code snippets modified here.

buenaflor and others added 3 commits May 12, 2025 12:56
@buenaflor buenaflor mentioned this pull request May 12, 2025
Open
@buenaflor
Copy link
Contributor Author

cc @kahest I'm updating the privacy and replay docs in this PR

@buenaflor buenaflor mentioned this pull request May 13, 2025
Open
kahest
kahest approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codeowner-assignment codeowner-assignment bot requested a review from a team May 14, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@coolguyzone coolguyzone coolguyzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v9]: Update docs on removed fields and update experimental features such as replay
3 participants
@buenaflor @kahest @coolguyzone