flutter min version test (#966)

Author: marandaneto

.github/workflows/min_version_test.yml

@@ -0,0 +1,34 @@
+name: min version test
+on:
+  push:
+    branches:
+      - main
+      - release/**
+  pull_request:
+defaults:
+  run:
+    shell: bash
+jobs:
+  build:
+    name: Build
+    runs-on: macos-latest
+    timeout-minutes: 30
+
+    steps:
+        - uses: actions/checkout@v3
+
+        - uses: actions/setup-java@v3
+          with:
+            distribution: 'adopt'
+            java-version: '11'
+
+        - uses: subosito/flutter-action@v2
+          with:
+            flutter-version: '2.0.0'
+
+        - name: Build
+          run: |
+            cd min_version_test
+            flutter pub get
+            flutter build ios --no-codesign
+            flutter build appbundle

CHANGELOG.md

@@ -2,8 +2,15 @@
 
 ## Unreleased
 
+### Features
+
+* Bump Flutter's min. supported version from 1.17.0 to 2.0.0 ([#966](https://github.com/getsentry/sentry-dart/pull/966))
+
+This should not break anything since the Dart's min. version is already 2.12.0 and Flutter 2.0.0 uses Dart 2.12.0
+
 ### Fixes
 
+* Back compatibility of Object.hash for Dart 2.12.0 ([#966](https://github.com/getsentry/sentry-dart/pull/966))
 * Fix back compatibility for OnErrorIntegration integration ([#965](https://github.com/getsentry/sentry-dart/pull/965))
 
 ## 6.8.1

dart/lib/src/client_reports/client_report_recorder.dart

@@ -1,6 +1,7 @@
 import 'package:meta/meta.dart';
 
 import '../sentry_options.dart';
+import '../utils/hash_code.dart';
 import 'client_report.dart';
 import 'discarded_event.dart';
 import 'discard_reason.dart';
@@ -43,7 +44,7 @@ class _QuantityKey {
   final DataCategory category;
 
   @override
-  int get hashCode => Object.hash(reason, category);
+  int get hashCode => hash2(reason.hashCode, category.hashCode);
 
   @override
   bool operator ==(dynamic other) {

dart/lib/src/utils/hash_code.dart

@@ -0,0 +1,24 @@
+// Borrowed from https://api.dart.dev/stable/2.17.6/dart-core/Object/hash.html
+// Since Object.hash(a, b) is only available from Dart 2.14
+
+// A per-isolate seed for hash code computations.
+final int _hashSeed = identityHashCode(Object);
+
+int _combine(int hash, int value) {
+  hash = 0x1fffffff & (hash + value);
+  hash = 0x1fffffff & (hash + ((0x0007ffff & hash) << 10));
+  return hash ^ (hash >> 6);
+}
+
+int hash2(int v1, int v2) {
+  int hash = _hashSeed;
+  hash = _combine(hash, v1);
+  hash = _combine(hash, v2);
+  return _finish(hash);
+}
+
+int _finish(int hash) {
+  hash = 0x1fffffff & (hash + ((0x03ffffff & hash) << 3));
+  hash = hash ^ (hash >> 11);
+  return 0x1fffffff & (hash + ((0x00003fff & hash) << 15));
+}

flutter/example/lib/main.dart

@@ -4,13 +4,15 @@ import 'dart:convert';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
+import 'package:logging/logging.dart';
 import 'package:sentry_flutter/sentry_flutter.dart';
 import 'package:universal_platform/universal_platform.dart';
 import 'package:feedback/feedback.dart' as feedback;
 import 'package:provider/provider.dart';
 import 'user_feedback_dialog.dart';
 import 'package:dio/dio.dart';
 import 'package:sentry_dio/sentry_dio.dart';
+import 'package:sentry_logging/sentry_logging.dart';
 
 // ATTENTION: Change the DSN below with your own to see the events in Sentry. Get one at sentry.io
 const String _exampleDsn =
@@ -28,6 +30,7 @@ Future<void> main() async {
       options.considerInAppFramesByDefault = false;
       options.attachThreads = true;
       options.enableWindowMetricBreadcrumbs = true;
+      options.addIntegration(LoggingIntegration());
     },
     // Init your App.
     appRunner: () => runApp(
@@ -391,6 +394,13 @@ class AndroidExample extends StatelessWidget {
         },
         child: const Text('Platform exception'),
       ),
+      ElevatedButton(
+        onPressed: () {
+          final log = Logger('Logging');
+          log.info('My Logging test');
+        },
+        child: const Text('Logging'),
+      ),
     ]);
   }
 }

flutter/example/pubspec.yaml

@@ -14,10 +14,12 @@ dependencies:
   sentry:
   sentry_flutter:
   sentry_dio:
+  sentry_logging:
   universal_platform: ^1.0.0-nullsafety
   feedback: ^2.0.0
   provider: ^6.0.0
   dio: ^4.0.0
+  logging: ^1.0.2
 
 dev_dependencies:
   pedantic: ^1.11.1
@@ -30,6 +32,8 @@ dependency_overrides:
     path: ../
   sentry_dio:
     path: ../../dio
+  sentry_logging:
+    path: ../../logging
 
 flutter:
   uses-material-design: true

flutter/pubspec.yaml

@@ -7,7 +7,7 @@ issue_tracker: https://github.com/getsentry/sentry-dart/issues
 
 environment:
   sdk: '>=2.12.0 <3.0.0'
-  flutter: '>=1.17.0'
+  flutter: '>=2.0.0'
 
 dependencies:
   flutter:

logging/README.md

@@ -24,6 +24,7 @@ Integration for the [`logging`](https://pub.dev/packages/logging) package.
 
 ```dart
 import 'package:sentry/sentry.dart';
+import 'package:sentry_logging/sentry_logging.dart';
 
 Future<void> main() async {
   await Sentry.init(

min_version_test/.gitignore

@@ -0,0 +1,44 @@
+# Miscellaneous
+*.class
+*.log
+*.pyc
+*.swp
+.DS_Store
+.atom/
+.buildlog/
+.history
+.svn/
+
+# IntelliJ related
+*.iml
+*.ipr
+*.iws
+.idea/
+
+# The .vscode folder contains launch configuration and tasks you configure in
+# VS Code which you may wish to be included in version control, so this line
+# is commented out by default.
+#.vscode/
+
+# Flutter/Dart/Pub related
+**/doc/api/
+**/ios/Flutter/.last_build_id
+.dart_tool/
+.flutter-plugins
+.flutter-plugins-dependencies
+.packages
+.pub-cache/
+.pub/
+/build/
+
+# Web related
+lib/generated_plugin_registrant.dart
+
+# Symbolication related
+app.*.symbols
+
+# Obfuscation related
+app.*.map.json
+
+# Exceptions to above rules.
+!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages

min_version_test/.metadata

@@ -0,0 +1,45 @@
+# This file tracks properties of this Flutter project.
+# Used by Flutter tool to assess capabilities and perform upgrades etc.
+#
+# This file should be version controlled.
+
+version:
+  revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+  channel: stable
+
+project_type: app
+
+# Tracks metadata for the flutter migrate command
+migration:
+  platforms:
+    - platform: root
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: android
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: ios
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: linux
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: macos
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: web
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+    - platform: windows
+      create_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+      base_revision: f1875d570e39de09040c8f79aa13cc56baab8db1
+
+  # User provided section
+
+  # List of Local paths (relative to this file) that should be
+  # ignored by the migrate tool.
+  #
+  # Files that are not part of the templates will be ignored by default.
+  unmanaged_files:
+    - 'lib/main.dart'
+    - 'ios/Runner.xcodeproj/project.pbxproj'