ref: Fix new Clippy lints

Author: szokeasaurusrex

src/api/data_types/deploy.rs

@@ -18,7 +18,7 @@ pub struct Deploy<'d> {
     pub projects: Option<Vec<Cow<'d, str>>>,
 }
 
-impl<'d> Deploy<'d> {
+impl Deploy<'_> {
     /// Returns the name of this deploy, defaulting to `"unnamed"`.
     pub fn name(&self) -> &str {
         match self.name.as_deref() {

src/api/mod.rs

@@ -1390,7 +1390,7 @@ impl<'a> AuthenticatedApi<'a> {
     }
 }
 
-impl<'a> RegionSpecificApi<'a> {
+impl RegionSpecificApi<'_> {
     fn request(&self, method: Method, url: &str) -> ApiResult<ApiRequest> {
         self.api
             .api

src/commands/react_native/xcode.rs

@@ -151,7 +151,7 @@ fn find_hermesc() -> String {
 /// The same as RN Tooling does it https://github.com/facebook/react-native/blob/435245978122d34a78014600562517c3bf96f92e/scripts/react-native-xcode.sh#L98C11-L98C11
 /// We ignore `USE_HERMES` as its behavior is not consistent between 0.65 - 0.72 and it the later versions it was removed as user override.
 fn is_hermes_enabled(hermesc: &String) -> bool {
-    return Path::new(hermesc).exists();
+    Path::new(hermesc).exists()
 }
 
 pub fn execute(matches: &ArgMatches) -> Result<()> {

src/utils/args.rs

@@ -84,7 +84,7 @@ pub trait ArgExt: Sized {
     fn version_arg(self, global: bool) -> Self;
 }
 
-impl<'a: 'b, 'b> ArgExt for Command {
+impl ArgExt for Command {
     fn org_arg(self) -> Command {
         self.arg(
             Arg::new("org")

src/utils/chunks.rs

@@ -148,7 +148,7 @@ impl<'data> AsRef<(Digest, &'data [u8])> for Chunk<'data> {
     }
 }
 
-impl<'data> ItemSize for Chunk<'data> {
+impl ItemSize for Chunk<'_> {
     fn size(&self) -> u64 {
         (self.0).1.len() as u64
     }

src/utils/dif.rs

@@ -181,7 +181,7 @@ impl<'a> std::ops::Deref for SelfProguard<'a> {
 impl<'slf> symbolic::common::AsSelf<'slf> for SelfProguard<'_> {
     type Ref = SelfProguard<'slf>;
 
-    fn as_self(&'slf self) -> &Self::Ref {
+    fn as_self(&'slf self) -> &'slf Self::Ref {
         self
     }
 }

src/utils/dif_upload.rs

@@ -86,7 +86,7 @@ enum ParsedDif<'a> {
 impl<'slf, 'data: 'slf> AsSelf<'slf> for ParsedDif<'data> {
     type Ref = ParsedDif<'data>;
 
-    fn as_self(&'slf self) -> &Self::Ref {
+    fn as_self(&'slf self) -> &'slf Self::Ref {
         self
     }
 }
@@ -275,7 +275,7 @@ impl<'data> DifMatch<'data> {
     }
 }
 
-impl<'data> fmt::Debug for DifMatch<'data> {
+impl fmt::Debug for DifMatch<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_struct("DifMatch")
             .field("name", &self.name)
@@ -314,7 +314,7 @@ impl<'data> Deref for HashedDifMatch<'data> {
     }
 }
 
-impl<'data> ItemSize for HashedDifMatch<'data> {
+impl ItemSize for HashedDifMatch<'_> {
     fn size(&self) -> u64 {
         self.deref().size()
     }
@@ -380,7 +380,7 @@ impl<'data> Deref for ChunkedDifMatch<'data> {
     }
 }
 
-impl<'data> ItemSize for ChunkedDifMatch<'data> {
+impl ItemSize for ChunkedDifMatch<'_> {
     fn size(&self) -> u64 {
         self.deref().size()
     }
@@ -402,7 +402,7 @@ enum DifSource<'a> {
     Zip(&'a mut ZipFileArchive, &'a str),
 }
 
-impl<'a> DifSource<'a> {
+impl DifSource<'_> {
     /// Resolves a file relative to the directory of `base`, stripping of the
     /// file name.
     fn get_relative_fs(base: &Path, path: &Path) -> Option<ByteView<'static>> {

src/utils/file_upload.rs

@@ -93,7 +93,7 @@ pub struct UploadContext<'a> {
     pub chunk_upload_options: Option<&'a ChunkUploadOptions>,
 }
 
-impl<'a> UploadContext<'a> {
+impl UploadContext<'_> {
     pub fn release(&self) -> Result<&str> {
         self.release
             .ok_or_else(|| anyhow!("A release slug is required (provide with --release)"))

src/utils/sourcemaps.rs

@@ -222,10 +222,10 @@ fn url_matches_extension(url: &str, extensions: &[&str]) -> bool {
 
 /// Return true iff url is a remote url (not a local path or embedded sourcemap).
 fn is_remote_url(url: &str) -> bool {
-    return match Url::parse(url) {
+    match Url::parse(url) {
         Ok(url) => url.scheme() != "data",
         Err(_) => false,
-    };
+    }
 }
 
 /// Return true if url appears to be a URL path.

src/utils/vcs.rs

@@ -17,7 +17,7 @@ pub enum GitReference<'a> {
     Symbolic(&'a str),
 }
 
-impl<'a> fmt::Display for GitReference<'a> {
+impl fmt::Display for GitReference<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match *self {
             GitReference::Commit(ref c) => write!(f, "{c}"),