Skip to content

Commit b2a741e

Browse files
ref(test): Use constant for expected request boundary (#2277)
Using a constant should make it clearer that this is a predefined, hardcoded value
1 parent e6e8bf3 commit b2a741e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tests/integration/debug_files/upload.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,14 @@ fn ensure_correct_chunk_upload() {
289289
#[test]
290290
/// This test verifies a correct chunk upload of multiple debug files.
291291
fn chunk_upload_multiple_files() {
292+
/// This is the boundary used in the expected request file.
293+
/// It was randomly generated when the expected request was recorded.
294+
const EXPECTED_REQUEST_BOUNDARY: &str = "------------------------b26LKrHFvpOPfwMoDhYNY8";
295+
292296
let expected_chunk_body = fs::read(
293297
"tests/integration/_expected_requests/debug_files/upload/chunk_upload_multiple_files.bin",
294298
)
295299
.expect("expected chunk body file should be present");
296-
// This is the boundary used in the expected request file.
297-
// It was randomly generated when the expected request was recorded.
298-
let boundary_of_expected_request = "------------------------b26LKrHFvpOPfwMoDhYNY8";
299300

300301
let is_first_assemble_call = AtomicBool::new(true);
301302
TestManager::new()
@@ -316,7 +317,7 @@ fn chunk_upload_multiple_files() {
316317

317318
let expected_chunks = chunk_upload::split_chunk_body(
318319
&expected_chunk_body,
319-
boundary_of_expected_request,
320+
EXPECTED_REQUEST_BOUNDARY,
320321
)
321322
.expect("expected chunk body is a valid multipart/form-data body");
322323

0 commit comments

Comments
 (0)