ref(profiling): make client sdk mandatory (#4853)

For continuous profiling (v2), the `client_sdk` is mandatory.

If missing, validation should fail and the chunk should be dropped.


Doc changes: getsentry/sentry-docs#14135

Author: viglia

CHANGELOG.md

@@ -5,6 +5,7 @@
 **Features**:
 
 - Add configuration to allow high cardinality tags in metrics. ([#4805](https://github.com/getsentry/relay/pull/4805))
+- Make client sdk mandatory for profile sample v2. ([#4853](https://github.com/getsentry/relay/pull/4853))
 
 **Internal**:
 

relay-profiling/src/sample/v2.rs

@@ -21,7 +21,6 @@ use crate::error::ProfileError;
 use crate::measurements::ChunkMeasurement;
 use crate::sample::{DebugMeta, Frame, ThreadMetadata, Version};
 use crate::types::ClientSdk;
-use crate::utils::default_client_sdk;
 
 const MAX_PROFILE_CHUNK_DURATION_SECS: f64 = MAX_PROFILE_CHUNK_DURATION.as_secs_f64();
 #[derive(Debug, Serialize, Deserialize)]
@@ -39,8 +38,7 @@ pub struct ProfileMetadata {
     pub platform: String,
     pub release: Option<String>,
 
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub client_sdk: Option<ClientSdk>,
+    pub client_sdk: ClientSdk,
 
     /// Hard-coded string containing "2" to indicate the format version.
     pub version: Version,
@@ -73,10 +71,6 @@ impl ProfileChunk {
     pub fn normalize(&mut self) -> Result<(), ProfileError> {
         let platform = self.metadata.platform.as_str();
 
-        if self.metadata.client_sdk.is_none() {
-            self.metadata.client_sdk = default_client_sdk(platform);
-        }
-
         self.profile.normalize(platform)
     }
 }

relay-profiling/src/types.rs

@@ -12,7 +12,5 @@ pub struct DebugMeta {
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct ClientSdk {
     pub name: String,
-
-    #[serde(default, skip_serializing_if = "String::is_empty")]
     pub version: String,
 }