You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, I want to say that the Lumino module is awesome, and nice.
However, I have noticed a couple of things:
Because of a deviation between the normal formatting of function calls, a couple of the module functions don't call the sub-functions. (I have a PR for this already: getreuer/qmk-modules#6).
Not a huge issue, since the issue I ran into with it can be worked around easily enough. (namely, I have a hacky config for rgblight to dump it's info into rgb matrix for multiple animations, and need to sync the value settings)
Also, instead of using QK_BOOT to add the shutdown/boot led, there is the shutdown_(module) hook.
Additionally, using the timeout option, it doesn't trigger the timer reset on encoder events nor does it trigger on pointing device movement. This is because it's using process_record_* function to reset the timer. However, it might be better to use last_input_activity_time or last_input_activity_elapsed, as these are reset on any activity (matrix, encoder, and pointing) and can provide a much more unified experience.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
First, I want to say that the Lumino module is awesome, and nice.
However, I have noticed a couple of things:
Because of a deviation between the normal formatting of function calls, a couple of the module functions don't call the sub-functions. (I have a PR for this already: getreuer/qmk-modules#6).
Not a huge issue, since the issue I ran into with it can be worked around easily enough. (namely, I have a hacky config for rgblight to dump it's info into rgb matrix for multiple animations, and need to sync the value settings)
Also, instead of using
QK_BOOT
to add the shutdown/boot led, there is theshutdown_(module)
hook.Additionally, using the timeout option, it doesn't trigger the timer reset on encoder events nor does it trigger on pointing device movement. This is because it's using
process_record_*
function to reset the timer. However, it might be better to uselast_input_activity_time
orlast_input_activity_elapsed
, as these are reset on any activity (matrix, encoder, and pointing) and can provide a much more unified experience.Beta Was this translation helpful? Give feedback.
All reactions