Handle additional error codes

It seems the 'detail' key referenced in commit d9c7ced is present for
404 cases. This means we can show a nice message for this particular
instance.

On the other hand, if there's a bug with the Patchwork server and a 5xx
code is raised, we should raise that promptly.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: #189

Author: stephenfin

git_pw/api.py

@@ -80,8 +80,17 @@ def _get_project():  # type: () -> str
 
 def _handle_error(operation, exc):
     if exc.response is not None and exc.response.content:
+        # server errors should always be reported
+        if exc.response.status_code in range(500, 512):  # 5xx Server Error
+            LOG.error('Server error. Please report this issue to '
+                      'https://github.com/getpatchwork/patchwork')
+            raise
+
         # we make the assumption that all responses will be JSON encoded
-        LOG.error(exc.response.json())
+        if exc.response.status_code == 404:
+            LOG.error('Resource not found')
+        else:
+            LOG.error(exc.response.json())
     else:
         LOG.error('Failed to %s resource. Is your configuration '
                   'correct?' % operation)

releasenotes/notes/handle-error-codes-d72c575fb2d9b452.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    HTTP 404 and HTTP 5xx errors are now handled correctly.