Skip to content

Commit 5a3341d

Browse files
committed
rpm: Address review comments
Address comments from [1]. In summary: - There's no need to define name and version macros - these are generated automatically - Requirements are emitted by the automatic Python dependency generator and don't need to be specified manually - Lines should be < 80 characters and not wrapped with an escape - Man pages may not be gzipped so don't assume this [1] https://bugzilla.redhat.com/show_bug.cgi?id=1830086#c1 Signed-off-by: Stephen Finucane <stephen@that.guru>
1 parent b0fa2e7 commit 5a3341d

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

rpm/git-pw.spec

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
%global name git-pw
2-
%define version 1.9.0
3-
4-
Name: %{name}
5-
Version: %{version}
1+
Name: git-pw
2+
Version: 1.9.0
63
Release: 1%{?dist}
74
Summary: Git-Patchwork integration tool
85

@@ -17,15 +14,9 @@ BuildRequires: python3-pbr
1714
BuildRequires: python3-setuptools
1815

1916
Requires: git
20-
Requires: python3-arrow
21-
Requires: python3-click
22-
Requires: python3-requests
23-
Requires: python3-setuptools
24-
Requires: python3-six
25-
Requires: python3-tabulate
2617

2718
%description
28-
git-pw is a tool for integrating Git with Patchwork, the web-based patch \
19+
git-pw is a tool for integrating Git with Patchwork, the web-based patch
2920
tracking system.
3021

3122
%prep
@@ -45,7 +36,7 @@ install -p -D -m 644 man/*.1 %{buildroot}%{_mandir}/man1/
4536
%license LICENSE
4637
%doc README.rst
4738
%{_bindir}/git-pw
48-
%{_mandir}/man1/git-pw*.1.gz
39+
%{_mandir}/man1/git-pw*.1*
4940
%{python3_sitelib}/git_pw/
5041
%{python3_sitelib}/git_pw-%{version}-py%{python3_version}*.egg-info
5142

0 commit comments

Comments
 (0)