web-forms (Vue UI): remove remnants of “unsupported control”

We now support all of the control types (at least partially)!

Author: eyelidlessness

packages/web-forms/src/components/FormQuestion.vue

@@ -13,7 +13,6 @@ import RangeControl from './controls/Range/RangeControl.vue';
 import RankControl from './controls/RankControl.vue';
 import SelectControl from './controls/SelectControl.vue';
 import TriggerControl from './controls/TriggerControl.vue';
-import UnsupportedControl from './controls/UnsupportedControl.vue';
 import UploadControl from './controls/Upload/UploadControl.vue';
 
 defineProps<{ question: ControlNode }>();
@@ -50,8 +49,6 @@ const submitPressed = inject('submitPressed');
 		<RangeControl v-else-if="isRangeNode(question)" :node="question" />
 
 		<TriggerControl v-else-if="isTriggerNode(question)" :question="question" />
-
-		<UnsupportedControl v-else :question="question" />
 	</div>
 </template>
 

packages/web-forms/src/components/controls/UnsupportedControl.vue

@@ -1,12 +1,11 @@
 import InputControl from '@/components/controls/Input/InputControl.vue';
-import SelectControl from '@/components/controls/SelectControl.vue';
 import RankControl from '@/components/controls/RankControl.vue';
-import UnsupportedControl from '@/components/controls/UnsupportedControl.vue';
+import SelectControl from '@/components/controls/SelectControl.vue';
+import FormQuestion from '@/components/FormQuestion.vue';
 import type { SelectNode } from '@getodk/xforms-engine';
 import { mount } from '@vue/test-utils';
 import { describe, expect, it } from 'vitest';
-import FormQuestion from '@/components/FormQuestion.vue';
-import { fakeUnsupportedControlNode, getReactiveForm, globalMountOptions } from '../helpers';
+import { getReactiveForm, globalMountOptions } from '../helpers';
 
 const mountComponent = async (formPath: string, questionNumber: number) => {
 	const xform = await getReactiveForm(formPath);
@@ -53,19 +52,4 @@ describe('FormQuestion', () => {
 		);
 		expect(component.find('#family_and_friends .rank-label').text()).toEqual('Family and Friends');
 	});
-
-	it('shows UnsupportedControl for unsupported / unimplemented question type', () => {
-		const component = mount(FormQuestion, {
-			props: {
-				question: fakeUnsupportedControlNode(),
-			},
-			global: globalMountOptions,
-		});
-
-		const unsupported = component.findComponent(UnsupportedControl);
-
-		expect(unsupported.exists()).toBe(true);
-
-		expect(component.text()).toEqual('Unsupported field {dummy} in the form definition.');
-	});
 });

packages/web-forms/tests/components/FormQuestion.test.ts

@@ -1,6 +1,6 @@
 import { xformFixturesByIdentifier } from '@getodk/common/fixtures/xforms.ts';
 import type { AnyFunction } from '@getodk/common/types/helpers.d.ts';
-import type { AnyControlNode, RootNode } from '@getodk/xforms-engine';
+import type { RootNode } from '@getodk/xforms-engine';
 import { createInstance } from '@getodk/xforms-engine';
 import type { MountingOptions } from '@vue/test-utils';
 import PrimeVue from 'primevue/config';
@@ -66,9 +66,6 @@ export const globalMountOptions: GlobalMountOptions = {
 	},
 };
 
-export const fakeUnsupportedControlNode = () =>
-	Object.assign({ nodeType: 'dummy', validationState: {} }, {} as AnyControlNode);
-
 // TODO: how the heck is `undefined` a key of anything?!
 type StringKeyOf<T> = Extract<keyof T, string>;