Skip to content

Commit c3716bf

Browse files
authored
chore(#319): runs E2E tests in CI (#361)
Fixes e2e about styles Removes unclear e2e vue test Runs e2e in CI
1 parent fd88153 commit c3716bf

File tree

4 files changed

+7
-102
lines changed

4 files changed

+7
-102
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,9 @@ jobs:
456456
- if: ${{ matrix.target == 'Web' && matrix.browser != 'webkit' }}
457457
run: 'yarn workspace @getodk/web-forms test-browser:${{ matrix.browser }}'
458458

459+
- if: ${{ matrix.target == 'Web' }}
460+
run: 'yarn workspace @getodk/web-forms test:e2e:${{ matrix.browser }}'
461+
459462
- if: ${{ matrix.node-version == '22.12.0' && matrix.target == 'Node' }}
460463
uses: actions/upload-artifact@v4
461464
with:

packages/web-forms/e2e/build/style.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ test('Build includes component-defined styles', async ({ page }) => {
44
await page.goto('http://localhost:5174/');
55

66
// This ensures that the application is loaded before proceeding forward.
7-
await expect(page.getByText('Demo Forms').first()).toBeVisible();
7+
await expect(page.getByText('ODK Web Forms Preview').first()).toBeVisible();
88

99
// Get the (Sass-defined) large breakpoint size
1010
// [In theory, if we can get this and it's not a number, we've already validated styles. Below expands on that to leave some breadcrumbs]

packages/web-forms/e2e/vue.test.ts

Lines changed: 0 additions & 101 deletions
This file was deleted.

packages/web-forms/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@
3535
"dist-demo": "yarn build && yarn vite serve dist-demo --port 5174",
3636
"test": "npm-run-all -nl test:*",
3737
"test:e2e": "playwright test",
38+
"test:e2e:chromium": "playwright test --project=chromium",
39+
"test:e2e:firefox": "playwright test --project=firefox",
40+
"test:e2e:webkit": "playwright test --project=webkit",
3841
"test-node:jsdom": "vitest run",
3942
"test-browser:chromium": "BROWSER_NAME=chromium vitest run",
4043
"test-browser:firefox": "BROWSER_NAME=firefox vitest run",

0 commit comments

Comments
 (0)