Skip to content

Commit f94f0a6

Browse files
kristoffSCkristoffSC
authored
Merge pull request #9 from getindata/checkstyle
checkstyle - add checkstyle based on delta.io/connectors checkstyle
2 parents 530ff66 + a86a976 commit f94f0a6

37 files changed

+1677
-1077
lines changed

‎CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- Package refactoring. Hide internal classes that does not have to be used by API users under "internal" package.
66
Methods defined in classes located outside "internal" package are considered "public API".
77
Any changes to those methods should be communicated as "not backward compatible" and should be avoided.
8+
- Add checkstyle configuration to "dev" folder. Add checkstyle check during maven build
89

910
## [0.2.0] - 2022-07-06
1011

‎dependency-reduced-pom.xml

Lines changed: 216 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,28 @@
44
<groupId>com.getindata</groupId>
55
<artifactId>flink-http-connector</artifactId>
66
<name>flink-http-connector</name>
7-
<version>1.0-SNAPSHOT</version>
7+
<version>0.3.0-SNAPSHOT</version>
8+
<description>The HTTP TableLookup connector that allows for pulling data from external system via HTTP GET method and HTTP Sink that allows for sending data to external system via HTTP requests. The goal for HTTP TableLookup connector was to use it in Flink SQL statement as a standard table that can be later joined with other stream using pure SQL Flink.</description>
9+
<url>https://github.com/getindata/flink-http-connector</url>
10+
<developers>
11+
<developer>
12+
<name>GetInData</name>
13+
<email>office@getindata.com</email>
14+
<organization>GetInData</organization>
15+
<organizationUrl>https://getindata.com</organizationUrl>
16+
</developer>
17+
</developers>
18+
<licenses>
19+
<license>
20+
<name>The Apache License, Version 2.0</name>
21+
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
22+
</license>
23+
</licenses>
24+
<scm>
25+
<connection>scm:git:git://github.com/getindata/flink-http-connector</connection>
26+
<developerConnection>scm:git:ssh://github.com/getindata/flink-http-connector</developerConnection>
27+
<url>https://github.com/getindata/flink-http-connector/tree/main</url>
28+
</scm>
829
<build>
930
<pluginManagement>
1031
<plugins>
@@ -62,6 +83,26 @@
6283
<version>3.0.0-M5</version>
6384
<configuration />
6485
</plugin>
86+
<plugin>
87+
<artifactId>maven-checkstyle-plugin</artifactId>
88+
<version>3.1.2</version>
89+
<executions>
90+
<execution>
91+
<id>checkstyle</id>
92+
<phase>validate</phase>
93+
<goals>
94+
<goal>check</goal>
95+
</goals>
96+
<configuration>
97+
<configLocation>dev/checkstyle.xml</configLocation>
98+
<encoding>UTF-8</encoding>
99+
<consoleOutput>true</consoleOutput>
100+
<failsOnError>true</failsOnError>
101+
<failOnViolation>true</failOnViolation>
102+
</configuration>
103+
</execution>
104+
</executions>
105+
</plugin>
65106
<plugin>
66107
<groupId>org.jacoco</groupId>
67108
<artifactId>jacoco-maven-plugin</artifactId>
@@ -158,8 +199,155 @@
158199
</execution>
159200
</executions>
160201
</plugin>
202+
<plugin>
203+
<groupId>org.codehaus.mojo</groupId>
204+
<artifactId>build-helper-maven-plugin</artifactId>
205+
<version>3.3.0</version>
206+
<executions>
207+
<execution>
208+
<id>parse-version</id>
209+
<goals>
210+
<goal>parse-version</goal>
211+
</goals>
212+
</execution>
213+
</executions>
214+
</plugin>
161215
</plugins>
162216
</build>
217+
<profiles>
218+
<profile>
219+
<id>release</id>
220+
<build>
221+
<plugins>
222+
<plugin>
223+
<artifactId>maven-javadoc-plugin</artifactId>
224+
<version>3.1.1</version>
225+
<executions>
226+
<execution>
227+
<id>attach-javadocs</id>
228+
<goals>
229+
<goal>jar</goal>
230+
</goals>
231+
</execution>
232+
</executions>
233+
<configuration>
234+
<links>
235+
<link>https://nightlies.apache.org/flink/flink-docs-release-1.15/api/java/</link>
236+
</links>
237+
</configuration>
238+
</plugin>
239+
<plugin>
240+
<artifactId>maven-source-plugin</artifactId>
241+
<version>3.2.0</version>
242+
<executions>
243+
<execution>
244+
<id>attach-sources</id>
245+
<goals>
246+
<goal>jar-no-fork</goal>
247+
</goals>
248+
</execution>
249+
</executions>
250+
</plugin>
251+
<plugin>
252+
<groupId>org.sonatype.plugins</groupId>
253+
<artifactId>nexus-staging-maven-plugin</artifactId>
254+
<version>1.6.13</version>
255+
<extensions>true</extensions>
256+
<configuration>
257+
<serverId>ossrh</serverId>
258+
<nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
259+
<autoReleaseAfterClose>true</autoReleaseAfterClose>
260+
</configuration>
261+
</plugin>
262+
<plugin>
263+
<artifactId>maven-gpg-plugin</artifactId>
264+
<version>3.0.1</version>
265+
<executions>
266+
<execution>
267+
<id>sign-artifacts</id>
268+
<phase>verify</phase>
269+
<goals>
270+
<goal>sign</goal>
271+
</goals>
272+
</execution>
273+
</executions>
274+
<configuration>
275+
<gpgArguments>
276+
<arg>--pinentry-mode</arg>
277+
<arg>loopback</arg>
278+
</gpgArguments>
279+
</configuration>
280+
</plugin>
281+
</plugins>
282+
</build>
283+
</profile>
284+
<profile>
285+
<id>bump-patch</id>
286+
<build>
287+
<plugins>
288+
<plugin>
289+
<groupId>org.codehaus.mojo</groupId>
290+
<artifactId>versions-maven-plugin</artifactId>
291+
<executions>
292+
<execution>
293+
<phase>validate</phase>
294+
<goals>
295+
<goal>set</goal>
296+
</goals>
297+
<configuration>
298+
<newVersion>${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.nextIncrementalVersion}-SNAPSHOT</newVersion>
299+
</configuration>
300+
</execution>
301+
</executions>
302+
</plugin>
303+
</plugins>
304+
</build>
305+
</profile>
306+
<profile>
307+
<id>bump-minor</id>
308+
<build>
309+
<plugins>
310+
<plugin>
311+
<groupId>org.codehaus.mojo</groupId>
312+
<artifactId>versions-maven-plugin</artifactId>
313+
<executions>
314+
<execution>
315+
<phase>validate</phase>
316+
<goals>
317+
<goal>set</goal>
318+
</goals>
319+
<configuration>
320+
<newVersion>${parsedVersion.majorVersion}.${parsedVersion.nextMinorVersion}.0-SNAPSHOT</newVersion>
321+
</configuration>
322+
</execution>
323+
</executions>
324+
</plugin>
325+
</plugins>
326+
</build>
327+
</profile>
328+
<profile>
329+
<id>bump-major</id>
330+
<build>
331+
<plugins>
332+
<plugin>
333+
<groupId>org.codehaus.mojo</groupId>
334+
<artifactId>versions-maven-plugin</artifactId>
335+
<executions>
336+
<execution>
337+
<phase>validate</phase>
338+
<goals>
339+
<goal>set</goal>
340+
</goals>
341+
<configuration>
342+
<newVersion>${parsedVersion.nextMajorVersion}.0.0-SNAPSHOT</newVersion>
343+
</configuration>
344+
</execution>
345+
</executions>
346+
</plugin>
347+
</plugins>
348+
</build>
349+
</profile>
350+
</profiles>
163351
<repositories>
164352
<repository>
165353
<releases>
@@ -198,10 +386,6 @@
198386
<artifactId>jsr305</artifactId>
199387
<groupId>com.google.code.findbugs</groupId>
200388
</exclusion>
201-
<exclusion>
202-
<artifactId>flink-shaded-force-shading</artifactId>
203-
<groupId>org.apache.flink</groupId>
204-
</exclusion>
205389
</exclusions>
206390
</dependency>
207391
<dependency>
@@ -226,28 +410,24 @@
226410
<artifactId>jsr305</artifactId>
227411
<groupId>com.google.code.findbugs</groupId>
228412
</exclusion>
229-
<exclusion>
230-
<artifactId>flink-shaded-force-shading</artifactId>
231-
<groupId>org.apache.flink</groupId>
232-
</exclusion>
233413
</exclusions>
234414
</dependency>
235415
<dependency>
236416
<groupId>org.apache.logging.log4j</groupId>
237417
<artifactId>log4j-slf4j-impl</artifactId>
238-
<version>2.14.1</version>
418+
<version>2.17.2</version>
239419
<scope>provided</scope>
240420
</dependency>
241421
<dependency>
242422
<groupId>org.apache.logging.log4j</groupId>
243423
<artifactId>log4j-api</artifactId>
244-
<version>2.14.1</version>
424+
<version>2.17.2</version>
245425
<scope>provided</scope>
246426
</dependency>
247427
<dependency>
248428
<groupId>org.apache.logging.log4j</groupId>
249429
<artifactId>log4j-core</artifactId>
250-
<version>2.14.1</version>
430+
<version>2.17.2</version>
251431
<scope>provided</scope>
252432
</dependency>
253433
<dependency>
@@ -268,10 +448,6 @@
268448
<artifactId>jsr305</artifactId>
269449
<groupId>com.google.code.findbugs</groupId>
270450
</exclusion>
271-
<exclusion>
272-
<artifactId>flink-shaded-force-shading</artifactId>
273-
<groupId>org.apache.flink</groupId>
274-
</exclusion>
275451
</exclusions>
276452
</dependency>
277453
<dependency>
@@ -303,12 +479,15 @@
303479
<artifactId>jsr305</artifactId>
304480
<groupId>com.google.code.findbugs</groupId>
305481
</exclusion>
306-
<exclusion>
307-
<artifactId>flink-shaded-force-shading</artifactId>
308-
<groupId>org.apache.flink</groupId>
309-
</exclusion>
310482
</exclusions>
311483
</dependency>
484+
<dependency>
485+
<groupId>org.apache.flink</groupId>
486+
<artifactId>flink-connector-base</artifactId>
487+
<version>1.15.0</version>
488+
<type>test-jar</type>
489+
<scope>test</scope>
490+
</dependency>
312491
<dependency>
313492
<groupId>org.apache.flink</groupId>
314493
<artifactId>flink-table-planner_2.12</artifactId>
@@ -335,10 +514,6 @@
335514
<artifactId>jsr305</artifactId>
336515
<groupId>com.google.code.findbugs</groupId>
337516
</exclusion>
338-
<exclusion>
339-
<artifactId>flink-shaded-force-shading</artifactId>
340-
<groupId>org.apache.flink</groupId>
341-
</exclusion>
342517
</exclusions>
343518
</dependency>
344519
<dependency>
@@ -379,10 +554,6 @@
379554
<artifactId>jsr305</artifactId>
380555
<groupId>com.google.code.findbugs</groupId>
381556
</exclusion>
382-
<exclusion>
383-
<artifactId>flink-shaded-force-shading</artifactId>
384-
<groupId>org.apache.flink</groupId>
385-
</exclusion>
386557
</exclusions>
387558
</dependency>
388559
<dependency>
@@ -411,10 +582,6 @@
411582
<artifactId>jsr305</artifactId>
412583
<groupId>com.google.code.findbugs</groupId>
413584
</exclusion>
414-
<exclusion>
415-
<artifactId>flink-shaded-force-shading</artifactId>
416-
<groupId>org.apache.flink</groupId>
417-
</exclusion>
418585
</exclusions>
419586
</dependency>
420587
<dependency>
@@ -487,9 +654,17 @@
487654
<artifactId>jsr305</artifactId>
488655
<groupId>com.google.code.findbugs</groupId>
489656
</exclusion>
657+
</exclusions>
658+
</dependency>
659+
<dependency>
660+
<groupId>org.apache.flink</groupId>
661+
<artifactId>flink-json</artifactId>
662+
<version>1.15.0</version>
663+
<scope>test</scope>
664+
<exclusions>
490665
<exclusion>
491-
<artifactId>flink-shaded-force-shading</artifactId>
492-
<groupId>org.apache.flink</groupId>
666+
<artifactId>jsr305</artifactId>
667+
<groupId>com.google.code.findbugs</groupId>
493668
</exclusion>
494669
</exclusions>
495670
</dependency>
@@ -515,10 +690,6 @@
515690
<artifactId>jsr305</artifactId>
516691
<groupId>com.google.code.findbugs</groupId>
517692
</exclusion>
518-
<exclusion>
519-
<artifactId>flink-shaded-force-shading</artifactId>
520-
<groupId>org.apache.flink</groupId>
521-
</exclusion>
522693
</exclusions>
523694
</dependency>
524695
<dependency>
@@ -654,10 +825,13 @@
654825
</dependencies>
655826
<distributionManagement>
656827
<repository>
657-
<id>gitlab</id>
658-
<name>gitlab</name>
659-
<url>${env.MAVEN_REPO_URL}</url>
828+
<id>ossrh</id>
829+
<url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
660830
</repository>
831+
<snapshotRepository>
832+
<id>ossrh</id>
833+
<url>https://s01.oss.sonatype.org/content/repositories/snapshots</url>
834+
</snapshotRepository>
661835
</distributionManagement>
662836
<properties>
663837
<scala.binary.version>2.12</scala.binary.version>
@@ -673,7 +847,7 @@
673847
<maven.compiler.target>${target.java.version}</maven.compiler.target>
674848
<assertj.core.version>3.21.0</assertj.core.version>
675849
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
676-
<log4j.version>2.14.1</log4j.version>
850+
<log4j.version>2.17.2</log4j.version>
677851
<target.java.version>11</target.java.version>
678852
</properties>
679853
</project>

0 commit comments

Comments
 (0)