Skip to content

Commit dacf108

Browse files
authored
[HTTP-64] move to junit 5 and fix junit failures (#72)
Signed-off-by: David Radley <david_radley@uk.ibm.com>
1 parent b403ff6 commit dacf108

File tree

4 files changed

+123
-87
lines changed

4 files changed

+123
-87
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
runs-on: ubuntu-latest
1919
strategy:
2020
matrix:
21-
flink: [ "1.15.0", "1.15.3", "1.16.1" ]
21+
flink: [ "1.16.3", "1.17.2", "1.18.1"]
2222
steps:
2323
- uses: actions/checkout@v3
2424

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## [Unreleased]
44

5+
### Fixed
6+
7+
Moved junit support to junit 5, allowing junits to be run against flink 1.17 and 1.18.
8+
59
## [0.12.0] - 2024-03-22
610

711
### Added

pom.xml

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,17 @@ under the License.
6868

6969
<!-- IMPORTANT: If you update Flink, remember to update link to its docs in maven-javadoc-plugin <links>
7070
section, omitting the patch part (so for 1.15.0 use 1.15). -->
71-
<flink.version>1.15.0</flink.version>
71+
<flink.version>1.16.3</flink.version>
7272

7373
<target.java.version>11</target.java.version>
7474
<scala.binary.version>2.12</scala.binary.version>
7575
<maven.compiler.source>${target.java.version}</maven.compiler.source>
7676
<maven.compiler.target>${target.java.version}</maven.compiler.target>
7777
<log4j.version>2.17.2</log4j.version>
7878
<lombok.version>1.18.22</lombok.version>
79-
<junit.jupiter.version>5.8.1</junit.jupiter.version>
79+
<junit4.version>4.13.2</junit4.version>
80+
<junit5.version>5.10.1</junit5.version>
81+
<junit.jupiter.version>${junit5.version}</junit.jupiter.version>
8082
<assertj.core.version>3.21.0</assertj.core.version>
8183
<mockito.version>4.0.0</mockito.version>
8284
<wiremock.version>2.27.2</wiremock.version>
@@ -167,24 +169,31 @@ under the License.
167169

168170
<dependency>
169171
<groupId>org.apache.flink</groupId>
170-
<artifactId>flink-table-common</artifactId>
172+
<artifactId>flink-test-utils</artifactId>
171173
<version>${flink.version}</version>
172-
<type>test-jar</type>
173174
<scope>test</scope>
174175
</dependency>
175176

176177
<dependency>
177178
<groupId>org.apache.flink</groupId>
178-
<artifactId>flink-connector-base</artifactId>
179+
<artifactId>flink-table-test-utils</artifactId>
180+
<version>${flink.version}</version>
181+
<scope>test</scope>
182+
</dependency>
183+
184+
<dependency>
185+
<groupId>org.apache.flink</groupId>
186+
<artifactId>flink-table-common</artifactId>
179187
<version>${flink.version}</version>
180188
<type>test-jar</type>
181189
<scope>test</scope>
182190
</dependency>
183191

184192
<dependency>
185193
<groupId>org.apache.flink</groupId>
186-
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
194+
<artifactId>flink-connector-base</artifactId>
187195
<version>${flink.version}</version>
196+
<type>test-jar</type>
188197
<scope>test</scope>
189198
</dependency>
190199

@@ -233,9 +242,9 @@ under the License.
233242
</dependency>
234243

235244
<dependency>
236-
<groupId>org.junit.jupiter</groupId>
237-
<artifactId>junit-jupiter-params</artifactId>
238-
<version>${junit.jupiter.version}</version>
245+
<groupId>org.junit.vintage</groupId>
246+
<artifactId>junit-vintage-engine</artifactId>
247+
<version>${junit5.version}</version>
239248
<scope>test</scope>
240249
</dependency>
241250

@@ -323,6 +332,8 @@ under the License.
323332
<exclude>**/HttpLookupConnectorOptions.class</exclude>
324333
<exclude>**/Slf4jHttpPostRequestCallback.class</exclude>
325334
<exclude>**/SelfSignedTrustManager.class</exclude>
335+
<exclude>org/apache/calcite**</exclude>
336+
<exclude>org/apache/flink**</exclude>
326337
</excludes>
327338
</configuration>
328339
<executions>

0 commit comments

Comments
 (0)