Skip to content

Commit d712792

Browse files
authored
Add missing tests (#130)
1 parent e14ae6a commit d712792

File tree

3 files changed

+71
-0
lines changed

3 files changed

+71
-0
lines changed

src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/ElasticSearchLiteQueryCreatorTest.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,25 @@
1818

1919
public class ElasticSearchLiteQueryCreatorTest {
2020

21+
22+
@Test
23+
public void testWithEmptyLookupResult() {
24+
25+
// GIVEN
26+
LookupRow lookupRow = new LookupRow();
27+
lookupRow.setLookupPhysicalRowDataType(DataTypes.STRING());
28+
29+
GenericRowData lookupDataRow = GenericRowData.of(StringData.fromString("val1"));
30+
31+
// WHEN
32+
var queryCreator = new ElasticSearchLiteQueryCreator(lookupRow);
33+
var createdQuery = queryCreator.createLookupQuery(lookupDataRow);
34+
35+
// THEN
36+
assertThat(createdQuery.getLookupQuery()).isEqualTo("");
37+
assertThat(createdQuery.getBodyBasedUrlQueryParameters()).isEmpty();
38+
}
39+
2140
@Test
2241
public void testQueryCreationForSingleQueryStringParam() {
2342

src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/GenericJsonQueryCreatorTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,18 @@ public void shouldSerializeToJson() {
5656
assertThat(lookupQuery.getBodyBasedUrlQueryParameters().isEmpty());
5757
assertThat(lookupQuery.getLookupQuery()).isEqualTo("{\"id\":11,\"uuid\":\"myUuid\"}");
5858
}
59+
60+
@Test
61+
public void shouldSerializeToJsonTwice() {
62+
GenericRowData row = new GenericRowData(2);
63+
row.setField(0, 11);
64+
row.setField(1, StringData.fromString("myUuid"));
65+
66+
// Call createLookupQuery two times
67+
// to check that serialization schema is not opened Two times.
68+
this.jsonQueryCreator.createLookupQuery(row);
69+
LookupQueryInfo lookupQuery = this.jsonQueryCreator.createLookupQuery(row);
70+
assertThat(lookupQuery.getBodyBasedUrlQueryParameters().isEmpty());
71+
assertThat(lookupQuery.getLookupQuery()).isEqualTo("{\"id\":11,\"uuid\":\"myUuid\"}");
72+
}
5973
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
package com.getindata.connectors.http.internal.table.lookup.querycreators;
2+
3+
import java.util.Collections;
4+
import java.util.Optional;
5+
6+
import org.apache.flink.configuration.ConfigOption;
7+
import org.apache.flink.configuration.ConfigOptions;
8+
import org.apache.flink.configuration.Configuration;
9+
import org.junit.jupiter.api.Test;
10+
import static org.assertj.core.api.Assertions.assertThat;
11+
12+
class QueryFormatAwareConfigurationTest {
13+
14+
private static final ConfigOption<String> configOption = ConfigOptions.key("key")
15+
.stringType()
16+
.noDefaultValue();
17+
18+
@Test
19+
public void testWithDot() {
20+
QueryFormatAwareConfiguration queryConfig = new QueryFormatAwareConfiguration(
21+
"prefix.", Configuration.fromMap(Collections.singletonMap("prefix.key", "val"))
22+
);
23+
24+
Optional<String> optional = queryConfig.getOptional(configOption);
25+
assertThat(optional.get()).isEqualTo("val");
26+
}
27+
28+
@Test
29+
public void testWithoutDot() {
30+
QueryFormatAwareConfiguration queryConfig = new QueryFormatAwareConfiguration(
31+
"prefix", Configuration.fromMap(Collections.singletonMap("prefix.key", "val"))
32+
);
33+
34+
Optional<String> optional = queryConfig.getOptional(configOption);
35+
assertThat(optional.get()).isEqualTo("val");
36+
}
37+
38+
}

0 commit comments

Comments
 (0)