LookupSource_TestRename - Source Test name change + remove unused method argument in source factory. (#20)

Signed-off-by: Krzysztof Chmielewski <krzysztof.chmielewski@getindata.com>

Signed-off-by: Krzysztof Chmielewski <krzysztof.chmielewski@getindata.com>

Author: kristoffSC

src/main/java/com/getindata/connectors/http/internal/table/lookup/HttpLookupTableSourceFactory.java

@@ -54,11 +54,7 @@ public DynamicTableSource createDynamicTableSource(Context context) {
 
         ReadableConfig readableConfig = helper.getOptions();
 
-        ResolvedSchema resolvedSchema = context.getCatalogTable().getResolvedSchema();
-        DataType physicalRowDataType =
-            toRowDataType(resolvedSchema.getColumns(), Column::isPhysical);
-
-        validateOptions(context, readableConfig, physicalRowDataType);
+        validateOptions(context, readableConfig);
 
         DecodingFormat<DeserializationSchema<RowData>> decodingFormat =
             helper.discoverDecodingFormat(
@@ -69,6 +65,11 @@ public DynamicTableSource createDynamicTableSource(Context context) {
         PollingClientFactory<RowData> pollingClientFactory = new RestTablePollingClientFactory();
         HttpLookupConfig lookupConfig = getHttpLookupOptions(readableConfig);
 
+        ResolvedSchema resolvedSchema = context.getCatalogTable().getResolvedSchema();
+
+        DataType physicalRowDataType =
+            toRowDataType(resolvedSchema.getColumns(), Column::isPhysical);
+
         return new HttpLookupTableSource(
             physicalRowDataType,
             pollingClientFactory,
@@ -101,10 +102,7 @@ private HttpLookupConfig getHttpLookupOptions(ReadableConfig config) {
     }
 
     // TODO FIX There is something ugly here. Verify with DataGenTableSourceFactory and refactor.
-    private void validateOptions(
-            Context context,
-            ReadableConfig readableConfig,
-            DataType physicalRowDataType) {
+    private void validateOptions(Context context, ReadableConfig readableConfig) {
 
         Set<ConfigOption<?>> allOptions = new HashSet<>();
         allOptions.addAll(optionalOptions());

src/test/java/com/getindata/connectors/http/internal/table/lookup/HttpLookupTableSourceITCaseTest.java

@@ -62,7 +62,7 @@ public void tearDown() {
     }
 
     @Test
-    public void testHttpDynamicSinkDefaultPost() throws Exception {
+    public void testHttpLookupJoin() throws Exception {
 
         setupServerStub(wireMockServer);