Skip to content

Enhancement: encode uri params for synology proxy #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2024
Merged

Enhancement: encode uri params for synology proxy #4414

merged 1 commit into from
Dec 15, 2024

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Dec 13, 2024 •
edited
Loading

Proposed change

See #4411 (comment)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon force-pushed the feature/syno-encode-params branch from 0e7bb28 to c260858 Compare December 13, 2024 18:59
@shamoon shamoon force-pushed the dev branch 4 times, most recently from 06fe724 to deff2f5 Compare December 15, 2024 23:36
@shamoon shamoon merged commit 93c18a8 into dev Dec 15, 2024
4 checks passed
@shamoon shamoon deleted the feature/syno-encode-params branch December 15, 2024 23:36
@shamoon
Copy link
Collaborator Author

shamoon commented Dec 16, 2024 •
edited
Loading

Fixed with: bc3adf1

@shamoon
Copy link
Collaborator Author

shamoon commented Dec 16, 2024

@Oupsman or @JazzFisch hello! Are either of you guys able to look at this? Basically:

  • Tried to push a change that would URI-encode username and passwords for synology (Theres a commit after this PR that I thought would fix it but figured easy to discuss here)
  • Asked a user in discord if they can test and they said its now throwing a 2FA error.
[2024-12-16T20:13:29.325Z] warn: <synologyProxyHandler> Unable to call http://192.168.1.2:5000/webapi/entry.cgi?api=SYNO.Core.System.Utilization&version=1&method=get&username=remotestatsdev&password=REDACTED.  code: 407, error: Authentication failed. 2FA enabled..

Obviously I cant test this against an actual device to figure out what the heck is going on...

No worries if not

shamoon added a commit that referenced this pull request Dec 18, 2024
@shamoon
Revert "Enhancement: encode uri params for synology proxy (#4414)"
d0eabf7 
This reverts commit 93c18a8.

Revert "Fix synology param encoding"

This reverts commit bc3adf1.

Revert "I think this will actually fix the synology handler"

This reverts commit 30fd42d.
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shamoon