acquisition fails to load very large number of stashtabs

[sesquipedalias]

hi there, as a standard player who also plays a couple of leagues a year I have literally thousands of stash tabs in standard...

acquisition starts downloading them, but gets stuck after several hundred... when I restart the app, it's back at 0, so it has to restart the entire process, so it fails again, and I never get anything downloaded

if it could save downloaded tabs without needing the entire operation to complete, everything should be fine after a few attempts...

thanks

[gerwaric]

I've created an issue for this: #113

1. Can I ask if you're using OAuth, or POESESSID?

2. Also, if you can run acquisition with debug logging, I would love to see the log file. I have some ideas about what might be happening, but seeing the logs would help me narrow it down.

The issue you're talking about is one that's bothered me for a while. Acquisition's design goes back to 2014 when nobody had thousands of tabs. I keep trying to work on a rewrite, but more immediate bugs keep coming up.

I'll start thinking about how to save progress incrementally. Ideally, I'd like acquisition to be able to download the list of tabs without their contents first, so you can just select the tabs you want instead of needing to download all of them. Maybe even select tabs by type, or by matching the tab names with a string or regular expression.

[sesquipedalias]

hey there
also, thanks for the great work, should have said from the start < 3

1. OAuth

2. Apologies, I turn off logging and feedback by instinct, based on how all the large corp's want to track everything. Will re-enable!

[gerwaric]

No worries. I'm like you as a user, but as a developer, I now understand why the engineers want more data. (Investors also want data, but that's completely different!)

Acquisition uses crash reporting, which uploads the crash dump (not any logs or any PII), but you can disable that from the login dialog.

[sesquipedalias]

acquisition_logs.zip

here are the logs!
they stopped updating a few hours ago, even though I had acquisition on and running the whole time
I hope it helps : )

(btw I said thousands of tabs but this only sees about 900 -- that's because the rest are in tab folders)

cheers!

[gerwaric]

Thanks! I'll take a look at that this evening.

I got some additional undocumented information on rate limiting from GGG today, so I already have an idea of where to start.

[gerwaric]

I made some changes that might have helped with this issue here:
https://github.com/gerwaric/acquisition/releases/tag/v0.13.4

However, another user is reporting an error I hadn't seen before, which might also be causing this issue.