improve test coverage

Author: scivision

+stdlib/+fileio/absolute_path.m

@@ -12,29 +12,29 @@
 % * abspath: absolute path, if determined
 
 arguments
-  p (1,:) string
+  p string {mustBeScalarOrEmpty}
 end
 
 % have to expand ~ first
-p = stdlib.fileio.expanduser(p);
+abspath = stdlib.fileio.expanduser(p);
 
-if ~stdlib.fileio.is_absolute_path(p)
-  % otherwise the default is Documents/Matlab, which is probably not wanted.
-  p = fullfile(pwd, p);
+if isempty(abspath)
+  return
 end
 
-abspath = p;
+if ~stdlib.fileio.is_absolute_path(abspath)
+  % otherwise the default is Documents/Matlab, which is probably not wanted.
+  abspath = fullfile(pwd, abspath);
+end
 
-for i = 1:length(abspath)
-  if ispc && startsWith(abspath(i), "\\")
-    % UNC path is not canonicalized
-    continue
-  end
-  try
-    abspath(i) = string(java.io.File(abspath(i)).getCanonicalPath());
-  catch excp
-    error("stdlib:fileio:absolute_path", "%s is not a canonicalizable path.  %s", abspath(i), excp.message)
-  end
+if ispc && startsWith(abspath, "\\")
+  % UNC path is not canonicalized
+  return
+end
+try
+  abspath = string(java.io.File(abspath).getCanonicalPath());
+catch excp
+  error("stdlib:fileio:absolute_path", "%s is not a canonicalizable path.  %s", abspath, excp.message)
 end
 
 end % function

+stdlib/+fileio/is_exe.m

@@ -8,7 +8,12 @@
 % * ok: boolean logical
 
 arguments
-  file (1,1) string {mustBeNonzeroLengthText}
+  file string {mustBeScalarOrEmpty}
+end
+
+if isempty(file)
+  ok = logical.empty;
+  return
 end
 
 if ~isfile(file)

+stdlib/+test/TestFileImpure.m

@@ -23,6 +23,8 @@ function test_makedir(tc)
 
 function test_which_name(tc)
 
+tc.verifyEmpty(stdlib.fileio.which(tempname))
+
 if ismac
   n = "ls";
 else
@@ -38,6 +40,10 @@ function test_which_name(tc)
 function test_is_exe_which_fullpath(tc)
 import matlab.unittest.constraints.IsFile
 
+tc.verifyEmpty(stdlib.fileio.is_exe(string.empty))
+tc.verifyFalse(stdlib.fileio.is_exe(""))
+tc.verifyFalse(stdlib.fileio.is_exe(tempname))
+
 n = "matlab";
 %% is_exe test
 p = fullfile(matlabroot, "bin", n);

+stdlib/+test/TestFilePure.m

@@ -32,8 +32,6 @@ function test_is_absolute_path(tc)
 tc.verifyTrue(is_absolute_path('~/foo'))
 if ispc
   tc.verifyTrue(is_absolute_path('x:/foo'))
-  tc.verifyEqual(is_absolute_path(["x:/abc", "x:/123", "", "c"]), [true, true, false, false])
-  tc.verifyTrue(all(is_absolute_path(["x:/abc"; "x:/123"])))
   tc.verifyFalse(is_absolute_path('/foo'))
 else
   tc.verifyTrue(is_absolute_path('/foo'))
@@ -61,10 +59,10 @@ function test_absolute_path(tc)
 pt1 = absolute_path("bar/../2foo");
 tc.verifyFalse(contains(pt1, ".."))
 
-va = absolute_path(["2foo", "4foo"]);
-tc.verifyFalse(any(startsWith(va, "2")))
-vs = extractBefore(va, 2);
-tc.verifyEqual(vs(1), vs(2))
+va = absolute_path("2foo");
+vb = absolute_path("4foo");
+tc.verifyFalse(startsWith(va, "2"))
+tc.verifyTrue(strncmp(va, vb, 2))
 
 tc.verifyEmpty(absolute_path(string.empty))
 tc.verifyEqual(absolute_path(""), string(pwd))