CMake < 3.21 needs PROJECT_IS_TOP_LEVEL defined to avoid error

Author: scivision

cmake/hdf5.cmake

@@ -57,12 +57,10 @@ set(hdf5_cmake_args
 -DHDF5_BUILD_CPP_LIB:BOOL=false
 -DBUILD_TESTING:BOOL=false
 -DHDF5_BUILD_EXAMPLES:BOOL=false
--DHDF5_BUILD_TOOLS:BOOL=$<NOT:$<BOOL:${hdf5_parallel}>>
+-DHDF5_BUILD_TOOLS:BOOL=true
 -DHDF5_ENABLE_PARALLEL:BOOL=$<BOOL:${hdf5_parallel}>
--DHDF5_BUILD_PARALLEL_TOOLS:BOOL=false
+-DHDF5_BUILD_PARALLEL_TOOLS:BOOL=$<BOOL:${hdf5_parallel}>
 )
-# https://github.com/HDFGroup/hdf5/issues/818  for broken ph5diff in HDF5_BUILD_TOOLS
-# avoid building tools as some HDF5 versions have build failures or broken tools
 
 #-DHDF5_USE_GNU_DIRS:BOOL=ON  # not yet, new for 1.14
 

options.cmake

@@ -2,6 +2,14 @@ message(STATUS "${PROJECT_NAME} ${PROJECT_VERSION} CMake ${CMAKE_VERSION} Toolch
 
 include(GNUInstallDirs)
 
+# this is NECESSARY for CMake 3.21 -- parent projects will error on CMake configure!
+if(CMAKE_VERSION VERSION_LESS 3.21)
+  get_property(not_top DIRECTORY PROPERTY PARENT_DIRECTORY)
+  if(NOT not_top)
+    set(PROJECT_IS_TOP_LEVEL true)
+ endif()
+endif()
+
 option(find "try to find libraries" on)
 
 option(${PROJECT_NAME}_COVERAGE "Code coverage tests")
@@ -12,17 +20,8 @@ option(concepts "conceptual testing, for devs only" off)
 
 option(CMAKE_TLS_VERIFY "Verify TLS certificates" on)
 
-if(BUILD_SHARED_LIBS AND MSVC)
-  message(WARNING "Intel oneAPI has trouble with shared libs in general on Windows, try
-    cmake -DBUILD_SHARED_LIBS=off")
-endif()
-
 option(h5fortran_BUILD_TESTING "build tests" ${PROJECT_IS_TOP_LEVEL})
 
-if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT AND PROJECT_IS_TOP_LEVEL)
-  set_property(CACHE CMAKE_INSTALL_PREFIX PROPERTY VALUE "${PROJECT_BINARY_DIR}/local")
-endif()
-
 set_property(DIRECTORY PROPERTY EP_UPDATE_DISCONNECTED true)
 
 # Necessary for shared library with Visual Studio / Windows oneAPI