Skip to content

Commit 026fddc

Browse files
committed
more notes in get_deflate mpi=.false. only
1 parent a105c91 commit 026fddc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/read/read.f90

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@
3838

3939

4040
module procedure get_deflate
41+
!! h5pget_filter_f doesn't work collectively, will crash on h5fclose_f
42+
!! if(mpi_id==0) with mpi_bcast does not work, same crash.
43+
!! better to use H5Pall_filters_avail_f when mpi=.true.
4144

4245
integer :: i, j, ierr
4346
integer :: flags !< bit pattern

src/tests/unit/test_deflate_props.f90

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ program test_deflate_props
2929

3030
if(mpi_id==0) then
3131
call test_get_deflate(fn1)
32-
!! only works with mpi=.false. else get file close error
32+
!! only works with mpi=.false. else get h5fclose error
3333
print *, 'OK: HDF5 get deflate'
3434
endif
3535

@@ -89,7 +89,6 @@ subroutine test_get_deflate(fn)
8989
type(hdf5_file) :: h5f
9090

9191
call h5f%open(fn, action='r', mpi=.false.)
92-
!! bug in HDF5? only works with MPI=.false.
9392

9493
if (h5f%parallel_compression) then
9594
if (.not. h5f%deflate("/A")) error stop "test_get_deflate: expected deflate MPI"

0 commit comments

Comments
 (0)