Skip to content

Commit ea64e17

Browse files
add a null check before using attrib (#978)
* resolves issue #973 add a null check before using attrib * Add pytest_httpserver and unit test * Remove live server URL * Mark online --------- Co-authored-by: sethg <sethg@geographika.co.uk>
1 parent 7ae09c7 commit ea64e17

File tree

4 files changed

+2015
-5
lines changed

4 files changed

+2015
-5
lines changed

owslib/iso.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,14 @@ def __init__(self, md=None):
224224
self.charset = None
225225
else:
226226
self.id = md.attrib.get('id')
227-
self.languagecode = md.find(
228-
util.nspath_eval('gmd:languageCode/gmd:LanguageCode', namespaces)).attrib.get('codeListValue')
229-
self.charset = md.find(
230-
util.nspath_eval('gmd:characterEncoding/gmd:MD_CharacterSetCode', namespaces)).attrib.get(
231-
'codeListValue')
227+
self.languagecode = None
228+
languagecode = md.find(util.nspath_eval('gmd:languageCode/gmd:LanguageCode', namespaces))
229+
if languagecode is not None:
230+
self.languagecode = languagecode.attrib.get('codeListValue')
231+
self.charset = None
232+
charset = md.find(util.nspath_eval('gmd:characterEncoding/gmd:MD_CharacterSetCode', namespaces))
233+
if charset is not None:
234+
self.charset = charset.attrib.get('codeListValue')
232235

233236

234237
class CI_Date(object):

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
flake8
33
pytest
44
pytest-cov
5+
pytest_httpserver
56
pytest-socket
67
Pillow
78
tox

0 commit comments

Comments
 (0)