From f8f98ea88a9cc24cc16ed1334b680f15524cd0e8 Mon Sep 17 00:00:00 2001 From: Martin Fleischmann Date: Mon, 2 Jun 2025 20:59:19 +0200 Subject: [PATCH 1/3] BUG: fix index in spatial partitions --- dask_geopandas/expr.py | 2 +- dask_geopandas/tests/io/test_arrow.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dask_geopandas/expr.py b/dask_geopandas/expr.py index c597da2..e5bcd06 100644 --- a/dask_geopandas/expr.py +++ b/dask_geopandas/expr.py @@ -233,7 +233,7 @@ def calculate_spatial_partitions(self): ) ).compute(), crs=self.crs, - ) + ).reset_index(drop=True) self.spatial_partitions = parts def _propagate_spatial_partitions(self, new_object): diff --git a/dask_geopandas/tests/io/test_arrow.py b/dask_geopandas/tests/io/test_arrow.py index a971c6e..646f91f 100644 --- a/dask_geopandas/tests/io/test_arrow.py +++ b/dask_geopandas/tests/io/test_arrow.py @@ -92,7 +92,10 @@ def test_roundtrip(tmp_path, naturalearth_lowres): assert_geodataframe_equal(result_gpd, df) # reading back also populates the spatial partitioning property ddf.calculate_spatial_partitions() - assert_geoseries_equal(result.spatial_partitions, ddf.spatial_partitions.envelope) + assert_geoseries_equal( + result.spatial_partitions, + ddf.spatial_partitions.envelope, + ) def test_roundtrip_s3(s3_resource, s3_storage_options, naturalearth_lowres): From f46984a6117cb08f8f7004503a775a4a1ec94edf Mon Sep 17 00:00:00 2001 From: Martin Fleischmann Date: Mon, 2 Jun 2025 20:59:53 +0200 Subject: [PATCH 2/3] make sure CI is actually red when failling --- .github/workflows/tests.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 89e37bd..1478f42 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -24,7 +24,6 @@ jobs: defaults: run: shell: bash -l {0} - continue-on-error: true strategy: matrix: os: [ubuntu-latest] From 5f5f38f2d956f1cd6e944d02ec8da84201b97116 Mon Sep 17 00:00:00 2001 From: Martin Fleischmann Date: Mon, 2 Jun 2025 21:03:30 +0200 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75e3b3b..4ba5b0a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,11 @@ Version 0.5.0 (upcoming) Deprecations and compatibility notes: -- The deprecated `geom_almost_equals` method has been removed. Use `geom_equals_exact` instead. +- The deprecated `geom_almost_equals` method has been removed. Use `geom_equals_exact` instead (#326). + +Bug fixes: + +- Fixed index in spatial partitions (#329). Version 0.4.3 (January, 2025)