Is nightly Rust required to build?

[ianthetechie]

I'm aware of #716 and #833. I am able to build with -Zinline-mir=no (requires nightly), but can't seem to build with stable Rust (currently 1.88) on the main branch. I've tried jacking up the recursion limit to 2048 and that still doesn't let it build on stable.

Is this a known ongoing issue? Or did I just catch it in a bad state? (The issue I hit was specifically with the gearrow-geo crate).

[kylebarron]

Hmm, this is unfortunate. No, ideally nightly Rust should not be required to build.

I tried to use workarounds for the existing crates (hence closing #716 and #833). I tested that geoarrow-array, geoarrow-schema, geoarrow-cast and geoparquet all build in release mode (it's only release mode that has an issue). I don't check this on CI because I don't want to wait for a release build on every CI run.

On geoarrow-geo I can confirm:

> cargo build -p geoarrow-geo --release
error[E0275]: overflow evaluating the requirement `<impl GeoArrowArrayAccessor<'a> as GeoArrowArrayAccessor<'_>>::Item: GeometryTrait`
  |
  = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`geoarrow_geo`)
  = note: required for `<... as GeometryCollectionTrait>::GeometryType<'_>` to implement `ToGeoGeometry<f64>`
  = note: the full name for the type has been written to '/Users/kyle/github/geoarrow/geoarrow-rs/target/release/deps/geoarrow_geo-8bdeb9ef39e43e3f.long-type-1864961926160306549.txt'
  = note: consider using `--verbose` to print the full type name to the console

I see this also prevents geodatafusion from building in release mode.

Even if I comment out all code in geoarrow-geo except for mod area, this still fails. So perhaps it's a core problem with trying to use traits in this way?

At the end of the day it would be ideal if rustc fixed their bug: rust-lang/rust#128887.

[kylebarron]

Should be fixed in #1241

[ianthetechie]

Thanks! I just tested with the latest main after your commits and am building again on stable :D

Makes sense on CI not typically running release. Those builds are crazy long. Thanks for the quick resolution!