Type: Fix modified check_ctor_args to pass default SRS_ID value in case of null (#488)

Author: satyamsoni2211

geoalchemy2/types/__init__.py

@@ -179,8 +179,9 @@ def process(bindvalue):
     @staticmethod
     def check_ctor_args(geometry_type, srid, dimension, use_typmod, nullable):
         try:
-            srid = int(srid)
-        except ValueError:
+            # passing default SRID if it is NULL from DB
+            srid = int(srid if srid is not None else -1)
+        except (ValueError, TypeError):
             raise ArgumentError("srid must be convertible to an integer")
         if geometry_type:
             geometry_type = geometry_type.upper()

tests/test_types.py

@@ -44,6 +44,16 @@ def test_get_col_spec(self):
         g = Geometry(srid=900913)
         assert g.get_col_spec() == "geometry(GEOMETRY,900913)"
 
+    def test_get_col_spec_no_srid(self):
+        g = Geometry(srid=None)
+        assert g.get_col_spec() == "geometry(GEOMETRY,-1)"
+
+    def test_get_col_spec_invalid_srid(self):
+        with pytest.raises(ArgumentError) as e:
+            g = Geometry(srid="foo")
+            g.get_col_spec()
+        assert str(e.value) == "srid must be convertible to an integer"
+
     def test_get_col_spec_no_typmod(self):
         g = Geometry(geometry_type=None)
         assert g.get_col_spec() == "geometry"