CUERipper: Log marks all tracks as "Copy OK" even if they may not be.

[newhoa]

I'll preface this with saying I'm relatively new to using CUERipper but have been testing out a lot of ripping programs and checking lots of their logs. So I apologize if I'm not understanding this correctly or if it isn't seen as an issue. Thanks!

---

When CUERipper completes a track, the EAC-style log marks the track as "Copy OK". This seems to happen whether the copy was or wasn't OK.

EAC has both a "Copy OK" and a "Copy finished" status when a track completes to distinguish whether a copy is actually okay, or simply completed with possible issues.

For example, if Test and Copy CRCs mismatch, or if a Suspicious position is found (or timing issue for EAC), CUERipper will mark it as "Copy OK". But EAC will mark these likely errors "Copy finished" as they likely aren't "OK". Rubyripper, which also uses EAC-style logs, also does this in similar cases or if there are bad/irrecoverable sectors per-track.

CUERipper log examples:

Here is an example of Test and Copy CRC mismatch being marked "Copy OK"

Here is an example of "Suspicious position" being marked "Copy OK"

Here is an example of a CUERipper and EAC log of the same disc, both with Suspicious position warning/error, showing that the track result status is different.

Following the EAC log standard or coming up with an alternative track completion status when there are possible conflicts/issues would be really helpful.

[ha-korth]

The "Copy OK" line is part of the "EAC Style" template to create the appearance of an EAC extraction log. This is one of several lines in the template that never changes. There isn't processing going on to decide whether or not that line is written or some alternate text should be written.
You can Ignore it or switch EAC log style to False so you can view the native log.