Fix "alg" claim for Ed25519

gbrlsnchs · gbrlsnchs · commit a8218c548bc4 · 2021-07-24T22:56:14.000-03:00
Reference: https://datatracker.ietf.org/doc/html/rfc8037#appendix-A.5.
diff --git a/ed25519.go b/ed25519.go
@@ -58,7 +58,7 @@ func NewEd25519(opts ...func(*Ed25519)) *Ed25519 {
 
 // Name returns the algorithm's name.
 func (*Ed25519) Name() string {
-	return "Ed25519"
+	return "EdDSA"
 }
 
 // Sign signs headerPayload using the Ed25519 algorithm.
diff --git a/ed25519_go1_12.go b/ed25519_go1_12.go
@@ -57,7 +57,7 @@ func NewEd25519(opts ...func(*Ed25519)) *Ed25519 {
 
 // Name returns the algorithm's name.
 func (*Ed25519) Name() string {
-	return "Ed25519"
+	return "EdDSA"
 }
 
 // Sign signs headerPayload using the Ed25519 algorithm.
diff --git a/ed25519_test.go b/ed25519_test.go
@@ -18,7 +18,7 @@ var (
 			payload:   tp,
 			verifyAlg: jwt.NewEd25519(jwt.Ed25519PrivateKey(ed25519PrivateKey1)),
 			wantHeader: jwt.Header{
-				Algorithm: "Ed25519",
+				Algorithm: "EdDSA",
 				Type:      "JWT",
 			},
 			wantPayload: tp,
@@ -30,7 +30,7 @@ var (
 			payload:   tp,
 			verifyAlg: jwt.NewEd25519(jwt.Ed25519PublicKey(ed25519PublicKey1)),
 			wantHeader: jwt.Header{
-				Algorithm: "Ed25519",
+				Algorithm: "EdDSA",
 				Type:      "JWT",
 			},
 			wantPayload: tp,
@@ -42,7 +42,7 @@ var (
 			payload:   tp,
 			verifyAlg: jwt.NewEd25519(jwt.Ed25519PrivateKey(ed25519PrivateKey2)),
 			wantHeader: jwt.Header{
-				Algorithm: "Ed25519",
+				Algorithm: "EdDSA",
 				Type:      "JWT",
 			},
 			wantPayload: testPayload{},
@@ -54,7 +54,7 @@ var (
 			payload:   tp,
 			verifyAlg: jwt.NewEd25519(jwt.Ed25519PublicKey(ed25519PublicKey2)),
 			wantHeader: jwt.Header{
-				Algorithm: "Ed25519",
+				Algorithm: "EdDSA",
 				Type:      "JWT",
 			},
 			wantPayload: testPayload{},

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func NewEd25519(opts ...func(Ed25519)) Ed25519 {`
`58`	`58`
`59`	`59`	`// Name returns the algorithm's name.`
`60`	`60`	`func (*Ed25519) Name() string {`
`61`		`- return "Ed25519"`
	`61`	`+ return "EdDSA"`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`// Sign signs headerPayload using the Ed25519 algorithm.`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func NewEd25519(opts ...func(Ed25519)) Ed25519 {`
`57`	`57`
`58`	`58`	`// Name returns the algorithm's name.`
`59`	`59`	`func (*Ed25519) Name() string {`
`60`		`- return "Ed25519"`
	`60`	`+ return "EdDSA"`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`// Sign signs headerPayload using the Ed25519 algorithm.`