-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
Desired behavior
We currently have a lot of repeated boilerplate code in each library that generates the conf/*.yaml and cmd*.rb files. It would be nice to provide some cmake helper functions. We could install that with ign-tools since it is related to this package.
For example in ign-transport:
- https://github.com/ignitionrobotics/ign-transport/blob/ignition-transport11_11.0.0/conf/CMakeLists.txt
- https://github.com/ignitionrobotics/ign-transport/blob/ignition-transport11_11.0.0/src/cmd/CMakeLists.txt#L63-L108
and also in ign-plugin
- https://github.com/ignitionrobotics/ign-plugin/blob/0da6f078a3b98c3ac962378272dd29c80b70b119/loader/conf/CMakeLists.txt
- https://github.com/ignitionrobotics/ign-plugin/blob/0da6f078a3b98c3ac962378272dd29c80b70b119/loader/src/cmd/CMakeLists.txt
The helper functions should be able to generate separate files for installation and testing.
Alternatives considered
- We could add cmake helper functions to ign-cmake.
- We could continue with the current approach that involves lots of duplicate code.
Implementation suggestion
Additional context
traversaro
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed